Revise disabled tests #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/revise-disabled-tests
branch
3 times, most recently
from
46b7abb to
8056db3
Compare
Bouncheck
reviewed
Jul 2, 2025
There was a problem hiding this comment.
Added some comments but i think it boils down to two general things:
Tests with ScyllaSkip that lose it, but remain skipped due to other annotations lose the description why they are skipped for Scylla. In those cases a comment or something would be helpful. Some are almost obvious (like scylla not supporting protocol v5 yet), some are less obvious like handle_id_changes_on_reprepare.
Tests that lose ScyllaSkip and are now enabled generally don't have Scylla versions they are valid for attached. Since they were once disabled I am assuming there are Scylla versions they don't work on.
While the gh actions check last two, they may still fail on driver matrix which also has an entry for 2024.1.
If they are fine for 2024.1 i think it's okay not to waste time finding the exact boundaries, but if some of them don't work on 2024.1 they could already be disabled for it. Otherwise the same work will need to be repeated for the matrix later on.
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/BoundStatementCcmIT.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/ExecutionInfoWarningsIT.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/ExecutionInfoWarningsIT.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/ExecutionInfoWarningsIT.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/NowInSecondsIT.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/PreparedStatementIT.java
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/PreparedStatementIT.java
Show resolved
Hide resolved
...s/src/test/java/com/datastax/oss/driver/core/loadbalancing/DefaultLoadBalancingPolicyIT.java
Show resolved
Hide resolved
integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/ZeroTokenNodesIT.java
Show resolved
Hide resolved
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/BaseCcmRule.java
Outdated
Show resolved
Hide resolved
|
Results:
|
dkropachev
force-pushed
the
dk/revise-disabled-tests
branch
from
8056db3 to
221e923
Compare
Bouncheck
requested changes
Jul 3, 2025
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/ExecutionInfoWarningsIT.java
Outdated
Show resolved
Hide resolved
dkropachev
force-pushed
the
dk/revise-disabled-tests
branch
2 times, most recently
from
6de6d6e to
28fd990
Compare
|
@Bouncheck , addressed all the problems, please take a look again. |
dkropachev
force-pushed
the
dk/revise-disabled-tests
branch
3 times, most recently
from
4d4a6b8 to
13b10e8
Compare
Bouncheck
approved these changes
Jul 4, 2025
integration-tests/src/test/java/com/datastax/oss/driver/core/cql/ExecutionInfoWarningsIT.java
Outdated
Show resolved
Hide resolved
| @@ -361,26 +422,39 @@ private void should_not_store_metadata_for_conditional_updates(CqlSession sessio | |||
| assertThat(row.getBoolean("[applied]")).isFalse(); | |||
| assertThat(row.getInt("a")).isEqualTo(5); | |||
| assertThat(row.getInt("b")).isEqualTo(5); | |||
| assertThat(row.getInt("c")).isEqualTo(5); | |||
| // assertThat(row.getInt("c")).isEqualTo(5); | |||
dkropachev
force-pushed
the
dk/revise-disabled-tests
branch
2 times, most recently
from
a79d32c to
0a89a46
Compare
Go over disabled tests and enable them. If test fails: 1. Make test framework ignore it with proper message 2. If it is scylla bug or test needs to be adjusted, create an issue and reference it 3. Fix test to match scylla behavior There are two ways to disable test for scylla: 1. Mark it with @ScyllaSkip 2. Mark it with any backend requirement annotation: @CassandraRequirement, @DseRequirement, @BackendRequirement; and do not add sylla-specific requirement.
Name does not reflect logic. This annotation makes test framework to skip all non-scylla backends.
dkropachev
force-pushed
the
dk/revise-disabled-tests
branch
from
0a89a46 to
3c11d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the following:
If test fails:
Consider that there are two ways to disable test for scylla: