Prevent starting null read watcher #508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #503
This issue happens when connection is opened and closed right away.
_loop_will_run
callsconn.close
on it, which removesself._read_watcher
from theconnection
and since connection stays inself._new_conns
on next iteration it will pick it up and try to startself._read_watcher
on it.Solution is to remove closed connection from
self._new_conns
and check ifself._read_watcher
is not None before starting it.Two fixes for follwing problem:
self._read_watcher
is notNone
before starting itself._new_conns
when it is destroyedPre-review checklist
I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/
.Fixes:
annotations to PR description.