Skip to content

Prevent starting null read watcher #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

Prevent starting null read watcher #508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17356d9
Make sure that _read_watcher is not empty before start it
dkropachev Jul 17, 2025
5726b7b
Make lbevreactor remove connection from new connections list on discard
dkropachev Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cassandra/io/libevreactor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,10 @@ def connection_created(self, conn):

def connection_destroyed(self, conn):
with self._conn_set_lock:
new_conns = self._new_conns.copy()
new_conns.discard(conn)
self._new_conns = new_conns

new_live_conns = self._live_conns.copy()
new_live_conns.discard(conn)
self._live_conns = new_live_conns
Expand Down Expand Up @@ -194,7 +198,8 @@ def _loop_will_run(self, prepare):
self._new_conns = set()

for conn in to_start:
conn._read_watcher.start()
if conn._read_watcher:
conn._read_watcher.start()

changed = True

Expand Down
Loading