Support ES2020 export ns from #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public readonly Identifier? Exported; | ||
|
|
||
| public ExportAllDeclaration(Literal source) : base(Nodes.ExportAllDeclaration) | ||
| public ExportAllDeclaration(Literal source, Identifier? exported) : base(Nodes.ExportAllDeclaration) |
Owner
There was a problem hiding this comment.
@lahma would it be better to create another ctor so it's not a breaking change?
Collaborator
There was a problem hiding this comment.
Good catch, as type is public and we don't have JS semantics where nothing matters having another constructor makes sense in minor release.
Collaborator
There was a problem hiding this comment.
Hard to say if there's any dependency, but follows semantic versioning.
Contributor
Author
There was a problem hiding this comment.
@lahma would it be better to create another ctor so it's not a breaking change?
I added another commit to this PR that adds another constructor
Collaborator
|
Great work @pluethi1 ! Could you check the constructor comment? Looks like ready for the prime time otherwise. |
lahma
approved these changes
Oct 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are basically the same as the PR addressing the same issue in the JS project jquery/esprima#2055
fixes #195