Skip to content

Fixing event pipeline provider type #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

MichaelGHSeg
Copy link
Contributor

Custom pipelines can now be set, plus a test to validate they are used.

didiergarcia
didiergarcia previously approved these changes Feb 28, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the event pipeline provider configuration to use a custom provider interface and validates its usage through new tests.

  • Updates Configuration.cs to accept IEventPipelineProvider instead of a concrete type.
  • Introduces new tests validating both standard and custom event pipeline provider implementations.

Reviewed Changes

File Description
Tests/Utilities/EventPipelineTest.cs Adds tests to validate that the event pipeline providers, both standard and custom, are used in the configuration.
Analytics-CSharp/Segment/Analytics/Configuration.cs Changes the parameter type for event pipeline provider to IEventPipelineProvider, supporting pluggable custom implementations.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

Tests/Utilities/EventPipelineTest.cs:225

  • [nitpick] Consider adding an assertion to verify that the event pipeline provider is actively processing or modifying events, to ensure complete test coverage of the provider integration.
analytics.Track("test");

Tests/Utilities/EventPipelineTest.cs:241

  • [nitpick] Consider asserting the exception message or adding further validation to ensure that the NotImplementedException is raised for the expected reason, if a specific message is available.
Assert.Throws<NotImplementedException>(() => {

@MichaelGHSeg MichaelGHSeg merged commit 6d875a0 into main Mar 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants