-
Notifications
You must be signed in to change notification settings - Fork 853
Bump SeiDB #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SeiDB #2435
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2435 +/- ##
==========================================
+ Coverage 51.55% 51.57% +0.02%
==========================================
Files 1541 1541
Lines 156512 156512
==========================================
+ Hits 80685 80725 +40
+ Misses 69736 69700 -36
+ Partials 6091 6087 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
6feb21f
to
8025e71
Compare
sudo make install-shared | ||
@echo '/usr/local/lib' | sudo tee /etc/ld.so.conf.d/rocksdb.conf | ||
@sudo ldconfig | ||
@echo "RocksDB installation complete!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious, do we have to build rocksdb every time? Would be nice to use pre-built libs if we can or even move that to another repo and pull from it as release artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to build it every time (thats why its a separate step). I added a note there that says "one time setup".
Yea I think we can build and distribute a .so or pre-built libs @masih but have noticed issues where its arch dependent and had problems running the same rocksdb binary on different machines. Can add that as a separate step, but to note, on a single machine you only need to install rocksdb once (and can make install seid as many times after that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have a readme to clarify the steps to migrate from pebble to rocksdb
Describe your changes and provide context
Testing performed to validate your change