Skip to content

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Oct 3, 2025

Describe your changes and provide context

  • Bumps sei-db to include change for rocksdb inclusion + makefile updates

Testing performed to validate your change

  • Verifying on node

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.57%. Comparing base (c436adb) to head (a17641a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2435      +/-   ##
==========================================
+ Coverage   51.55%   51.57%   +0.02%     
==========================================
  Files        1541     1541              
  Lines      156512   156512              
==========================================
+ Hits        80685    80725      +40     
+ Misses      69736    69700      -36     
+ Partials     6091     6087       -4     
Flag Coverage Δ
sei-chain 27.54% <ø> (-0.01%) ⬇️
sei-cosmos 51.64% <ø> (+<0.01%) ⬆️
sei-tendermint 58.68% <ø> (+0.16%) ⬆️
sei-wasmd 51.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kbhat1 Kbhat1 force-pushed the BumpSeidbSeicosmosMono branch from 6feb21f to 8025e71 Compare October 3, 2025 20:08
sudo make install-shared
@echo '/usr/local/lib' | sudo tee /etc/ld.so.conf.d/rocksdb.conf
@sudo ldconfig
@echo "RocksDB installation complete!"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious, do we have to build rocksdb every time? Would be nice to use pre-built libs if we can or even move that to another repo and pull from it as release artifacts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to build it every time (thats why its a separate step). I added a note there that says "one time setup".

Yea I think we can build and distribute a .so or pre-built libs @masih but have noticed issues where its arch dependent and had problems running the same rocksdb binary on different machines. Can add that as a separate step, but to note, on a single machine you only need to install rocksdb once (and can make install seid as many times after that)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have a readme to clarify the steps to migrate from pebble to rocksdb

@Kbhat1 Kbhat1 merged commit 4a5eeab into main Oct 8, 2025
144 of 156 checks passed
@Kbhat1 Kbhat1 deleted the BumpSeidbSeicosmosMono branch October 8, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants