-
Notifications
You must be signed in to change notification settings - Fork 854
Bump SeiDB #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bump SeiDB #2435
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1d4ad4e
Bump SeiDB
Kbhat1 98c909f
Update installation instructions
Kbhat1 71f8aa2
build rocksdb
Kbhat1 8025e71
TEST - revert seidb changes
Kbhat1 ee330a7
update go work
Kbhat1 ed275b8
Bump sei-db
Kbhat1 1a99bff
Merge branch 'main' into BumpSeidbSeicosmosMono
Kbhat1 c8c4028
Bump seidb
Kbhat1 5928279
Bump seidb
Kbhat1 d994827
Merge branch 'main' into BumpSeidbSeicosmosMono
Kbhat1 de5b939
Bump seidb
Kbhat1 40adf9e
Go work
Kbhat1 12c3f18
Seidb 0.0.54
Kbhat1 38833ef
go work sum
Kbhat1 0e80095
Go work sum
Kbhat1 203c057
Merge branch 'main' into BumpSeidbSeicosmosMono
Kbhat1 ea6857c
v0.0.55 seidb
Kbhat1 8846f51
Merge branch 'main' into BumpSeidbSeicosmosMono
Kbhat1 a17641a
Merge branch 'main' into BumpSeidbSeicosmosMono
Kbhat1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious, do we have to build rocksdb every time? Would be nice to use pre-built libs if we can or even move that to another repo and pull from it as release artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to build it every time (thats why its a separate step). I added a note there that says "one time setup".
Yea I think we can build and distribute a .so or pre-built libs @masih but have noticed issues where its arch dependent and had problems running the same rocksdb binary on different machines. Can add that as a separate step, but to note, on a single machine you only need to install rocksdb once (and can make install seid as many times after that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have a readme to clarify the steps to migrate from pebble to rocksdb