Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StorageNode.EntityFetchQueryCache per-Domain #361

Merged
merged 14 commits into from
Mar 4, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Mar 3, 2025

This cache's key & value don't depend on StorageNode.
We need not ~1700 copies of the cache
image

Also:

  • Refactor HashCode calculation
  • Make EntitySetFetchQueryCache & RefsToEntityQueryCache per-Domain as well
  • Refactor GetColumnsToBeLoaded() to return array instead of List<>, because it always stored in Cache
  • Make RootContainerCacheEntry record struct
  • Make PersistenceState a byte enum to save each Entity size
  • Make TypeReferenceAccuracy a byte enum

@SergeiPavlov SergeiPavlov changed the title Make StorageNode.EntityFetchQueryCache static Make StorageNode.EntityFetchQueryCache per-Domain Mar 3, 2025
@botinko
Copy link

botinko commented Mar 3, 2025

Wow much better approach!

@SergeiPavlov SergeiPavlov merged commit b2d78f2 into master-servicetitan Mar 4, 2025
4 checks passed
@SergeiPavlov SergeiPavlov deleted the EntityFetchQueryCache branch March 4, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants