feat: donate cta #1701

Aerilym · 2025-11-19T05:35:00Z

No description provided.

Copilot

Pull Request Overview

This PR introduces functionality to retrieve database creation timestamps for triggering Call-to-Action (CTA) dialogs, and refactors the Pro Info Modal system into a more generalized CTA system that supports both Pro-related and donation CTAs.

Added a new utility function getFileCreationTimestampMs to safely retrieve file creation timestamps with proper error handling
Refactored SessionProInfoModal into SessionCTA to support multiple CTA variants beyond Pro features
Introduced donation CTA functionality that triggers 7 days after database creation

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
ts/node/fs_utility.ts	New utility function to get file creation timestamps with validation and error handling
ts/node/sql.ts	Adds `getDBCreationTimestampMs` function and exports it
ts/data/dataInit.ts	Registers the new `getDBCreationTimestampMs` channel
ts/data/data.ts	Exposes `getDBCreationTimestampMs` through the Data layer
ts/util/logger/rotatingPinoDest.ts	Updates log rotation to use the new utility function with null safety
ts/components/dialog/cta/types.ts	Defines new `CTAVariant` enum with Pro and donation variants
ts/components/dialog/SessionCTA.tsx	Refactored and generalized modal supporting both Pro and donation CTAs
ts/components/dialog/ProCTATitle.tsx	Extracted Pro-specific title logic into separate component
ts/components/dialog/ProCTADescription.tsx	Extracted Pro-specific description logic into separate component
ts/components/dialog/CTADescriptionList.tsx	Reusable component for CTA feature lists
ts/components/leftpane/ActionsPanel.tsx	Triggers donation CTA after 7 days of database existence
ts/state/ducks/modalDialog.tsx	Renamed action from `updateSessionProInfoModal` to `updateSessionCTA`
ts/state/onboarding/ducks/modals.ts	Updates type references from `SessionProInfoState` to `SessionCTAState`
ts/state/ducks/conversations.ts	Updates function call to `handleTriggeredProCTAs`
ts/components/dialog/DefaultSettingsPage.tsx	Updates donation URL to use getsession.org
ts/components/basic/SessionButton.tsx	Refactors hover color logic for solid buttons
Multiple component files	Updates imports and references from Pro-specific to generalized CTA system

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-19T05:51:52Z

ts/components/dialog/SessionCTA.tsx

+      // FIXME: replace with localised string
+      return 'Skip';


The FIXME comment indicates this button text needs localization. This should be addressed before merging or tracked in a follow-up issue to ensure proper internationalization support.

Suggested change

// FIXME: replace with localised string

return 'Skip';

// Use localized string for "Skip"

return tr('skip');

ts/node/fs_utility.ts

ts/components/leftpane/ActionsPanel.tsx

Copilot · 2025-11-19T05:51:53Z

ts/components/basic/SessionButton.tsx

      color: ${props =>
-        props.isDarkTheme && props.color && props.color !== SessionButtonColor.Tertiary
-          ? `var(--${props.color}-color)`
-          : `var(--button-solid-text-hover-color)`};
-      border: 1px solid
-        ${props =>
-          props.isDarkTheme && props.color
+        props.isDarkTheme
+          ? props.color && props.color !== SessionButtonColor.Tertiary
            ? `var(--${props.color}-color)`
-            : `var(--button-solid-text-hover-color)`};
+            : 'var(--primary-color)'
+          : `var(--button-solid-text-hover-color)`};


The nested ternary operator logic is difficult to read and understand. Consider refactoring to use a more explicit conditional structure:

color: ${props => { if (props.isDarkTheme) { return props.color && props.color !== SessionButtonColor.Tertiary ? `var(--${props.color}-color)` : 'var(--primary-color)'; } return 'var(--button-solid-text-hover-color)'; }};

This makes the logic clearer and easier to maintain.

Copilot · 2025-11-19T05:51:54Z

ts/components/dialog/SessionCTA.tsx

+      // FIXME: replace with localised string
+      return 'Session Needs Your Help';


The FIXME comment indicates this string needs localization. This should be addressed before merging or tracked in a follow-up issue to ensure proper internationalization support.

Suggested change

// FIXME: replace with localised string

return 'Session Needs Your Help';

// Localized string for donate generic CTA

return tr(MergedLocalizerTokens.cta_donate_generic_title);

Copilot · 2025-11-19T05:51:54Z

ts/components/dialog/SessionCTA.tsx

+      // FIXME: replace with localised string
+      return (
+        <>
+          {`Session is fighting powerful forces trying to weaken privacy, but we can’t continue this fight alone.`}
+          <br />
+          <br />
+          {`Donating keeps Session secure, independent, and online.`}
+        </>


The FIXME comment indicates this description needs localization. This should be addressed before merging or tracked in a follow-up issue to ensure proper internationalization support.

Copilot · 2025-11-19T05:51:54Z

ts/components/dialog/SessionCTA.tsx

+          {/** FIXME: replace with localised string */}
+          Donate


The FIXME comment indicates this button text needs localization. This should be addressed before merging or tracked in a follow-up issue to ensure proper internationalization support.

Suggested change

{/** FIXME: replace with localised string */}

Donate

{/** FIXME removed: now using localised string */}

{tr('donate')}

Bilb · 2025-11-19T05:58:08Z

ts/components/leftpane/ActionsPanel.tsx

+    // TODO: add checks around if the user has interacted with the donation url dialog before
+    const interacted = false;
+    if (!interacted) {


you have everything you need to do this now, correct?

Bilb · 2025-11-19T06:02:11Z

ts/components/dialog/SessionCTA.tsx

+    case CTAVariant.NIL:
+      return null;


what does this corresponds to?

ts/util/urlHistory.ts

Bilb · 2025-11-20T00:32:53Z

ts/util/urlHistory.ts

+  const rawInteractions = Storage.get(SettingsKey.urlInteractions);
+  const result = UrlInteractionsSchema.safeParse(rawInteractions);
+  if (result.error) {
+    window?.log?.error(`faild to parse ${SettingsKey.urlInteractions}`, result.error);


Suggested change

window?.log?.error(`faild to parse ${SettingsKey.urlInteractions}`, result.error);

window?.log?.error(`failed to parse ${SettingsKey.urlInteractions}`, result.error);

Bilb · 2025-11-20T00:34:08Z

ts/util/urlHistory.ts

+export function urlInteractionToString(interaction: URLInteraction) {
+  switch (interaction) {
+    case URLInteraction.OPEN:
+      return 'Open';
+    case URLInteraction.COPY:
+      return 'Copy';
+    case URLInteraction.TRUST:
+      return 'Trust';
+    default:
+      return 'Unknown';
+  }
+}


this is debug only, but should it be using the corresponding localised strings ) if we have them?

ts/util/urlHistory.ts

Bilb · 2025-11-20T05:24:46Z

ts/components/dialog/cta/types.ts

+type VariantForNonGroupFeature = (typeof variantsForNonGroupFeatures)[number];
+
+export function isProCTAFeatureVariant(variant: CTAVariant): variant is VariantForNonGroupFeature {
+  return variantsForNonGroupFeatures.includes(variant as any);


could be as number I reckon

Bilb · 2025-11-20T05:26:32Z

ts/components/dialog/SessionCTA.tsx

+  width: 100%;
+  height: 100%;
+  object-fit: cover;
+  object-position: right center;


does this need to be dependent on rtl?

The whole modal has rtl now so it supports rtl 🥳

…y times

…ch_logic feat: schedule pro details fetch jobs based on proof and access expir…

…restart_edge_case fix: cleanup pro expiry ctas when pro resets

Aerilym added 2 commits November 19, 2025 13:32

feat: get database creation time for use in cta triggers

04f9a34

feat: make ctas generic and create donate cta

40ee2ea

Aerilym requested review from Bilb and Copilot and removed request for Copilot November 19, 2025 05:35

Copilot started reviewing on behalf of Aerilym November 19, 2025 05:35 View session

Copilot finished reviewing on behalf of Aerilym November 19, 2025 05:36

fix: primary solid button hover colours

8cad96b

Copilot AI review requested due to automatic review settings November 19, 2025 05:48

Copilot started reviewing on behalf of Aerilym November 19, 2025 05:48 View session

Copilot finished reviewing on behalf of Aerilym November 19, 2025 05:50

Copilot AI reviewed Nov 19, 2025

View reviewed changes

Aerilym changed the title ~~feat: get database creation time for use in cta triggers~~ feat: donate cta Nov 19, 2025

fix: time based db creation trigger

3163c1a

Bilb reviewed Nov 19, 2025

View reviewed changes

Aerilym added 4 commits November 20, 2025 11:09

feat: url interaction history management

9c0f0d5

chore: update libsession-nodejs to 0.6.2

7e84bc0

fix: use url interaction for donate cta tirgger

7fa8fdb

chore: error log typo

f3cfa9b

Bilb reviewed Nov 20, 2025

View reviewed changes

Aerilym force-pushed the feat/donate_cta branch from c1ea465 to f3cfa9b Compare November 20, 2025 00:39

chore: remove nil cta enum case

b575725

Bilb reviewed Nov 20, 2025

View reviewed changes

Aerilym and others added 7 commits November 20, 2025 16:47

chore: cast schema checking type as number

2fb4341

chore: make debug menu ltr

921a093

chore: add env variable to override db creation timestamp

51d3ace

feat: schedule pro details fetch jobs based on proof and access expir…

69704cc

…y times

fix: move all cta time triggering logic to the same function

910240f

fix: clamp auto refresh task scheduler

57e6d83

Merge pull request #1704 from session-foundation/feat/pro_proof_refet…

03b651a

…ch_logic feat: schedule pro details fetch jobs based on proof and access expir…

Aerilym and others added 4 commits November 21, 2025 15:16

fix: remove unused ts-expect-error

1326bc1

fix: cleanup pro expiry ctas when pro resets

cf49948

chore: cleanup comment typo

5d1abb0

Merge pull request #1705 from session-foundation/fix/expired_pro_cta_…

f2e92a7

…restart_edge_case fix: cleanup pro expiry ctas when pro resets

		// FIXME: replace with localised string
		return 'Session Needs Your Help';

-          {/** FIXME: replace with localised string */}
-          Donate
+          {/** FIXME removed: now using localised string */}
+          {tr('donate')}

	window?.log?.error(`faild to parse ${SettingsKey.urlInteractions}`, result.error);
	window?.log?.error(`failed to parse ${SettingsKey.urlInteractions}`, result.error);

feat: donate cta #1701

Are you sure you want to change the base?

feat: donate cta #1701

Uh oh!

Conversation

Aerilym commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Bilb Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Bilb Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bilb Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Bilb Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bilb Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Bilb Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Aerilym Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants