fix: handle undefined options in number abbrev

[firebomb1]

Description

Handling of options which have an unidentified value when abbreviating numbers (e.g. coming from components with optional props without default values) in order for them to not override the defaults set based on the number being formatted.

This fixes a bug which was visible in the Price Chart tooltip, the number of fractional digits for low value assets was not dynamic and always set at the default value of Intl.NumberFormat for currencies (2) because the default was always overridden by undefined.

The "10" default for maximumFractionDigits mentioned above is also removed to the benefit of the dynamic computation that was already done but not used either for a reason I don't know. This was used because later the number is truncated instead of rounded, I didn't understand this at first.

Notice

• Have you followed the guidelines in our Contributing guide?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #3854

Risk

Modifies the logic for fiat amounts formatting across the whole app.

Testing

Engineering

Operations

• Verify that the Price Chart tooltip works for low/high fiat value assets and display more precise numbers for low value assets.
• Verify that amounts in fiat displayed across the app still respect the format we previously used.

Screenshots (if applicable)

Price Chart tooltip after the fix:

2023-02-17_11-41-18.webm

[firebomb1]

This is a draft until Product gives their OK for altering the current values displayed by the Price Chart tooltip, I've asked them on Discord and will update when there is an answer.

If the values must remain imprecise for some reason, I still think the underlying bug should be fixed, but then we'll need to set a "2" for the maximumFractionDigits of that tooltip usage of <Amount.Fiat>.

[0xdef1cafe]

@firebomb1 you may get stomped on by the large @pastaghost here - he's got a very nice suggestion w.r.t how we handle asset values that may or may not capture this - have a chat to him

[0xdef1cafe]

@DiggyDiggy2 @reallybeard are ok with this conceptually, let's not block on @pastaghost AssetValue changes as those are a ways out

[pastaghost]

@DiggyDiggy2 @reallybeard are ok with this conceptually, let's not block on @pastaghost AssetValue changes as those are a ways out

Agreed. AssetService is going to take a day or two as I'm trying to button up the KeepKey work right now.

[pastaghost]

@0xdef1cafe
Update: I've got a PR open for AssetValue here: shapeshift/lib#1206

[firebomb1]

Thanks for the link, the new lib will deal with crypto value handling/formatting and the current issue/PR relate to fiat value formatting, so while complementary at some point (to get a fiat balance) they should not impact each other as far as I can see.

[gomesalexandre]

Tested locally, LGTM! Great PR once again @firebomb1 🐐