Skip to content

fix: handle undefined options in number abbrev #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gomesalexandre merged 5 commits into from
Feb 23, 2023
Merged

fix: handle undefined options in number abbrev #3860

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4147dc7
fix: handle undefined options in number abbrev
firebomb1 Feb 17, 2023
dafd75c
fix: restore large fraction digits before truncate
firebomb1 Feb 17, 2023
86eb84c
fix: comment on fraction digits before truncate
firebomb1 Feb 17, 2023
0126642
Merge branch 'develop' into fix-price-chart-digits
gomesalexandre Feb 23, 2023
ed0caf2
fix: handle empty options without undef
firebomb1 Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/hooks/useLocaleFormatter/useLocaleFormatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,19 @@ export const useLocaleFormatter = (args?: useLocaleFormatterArgs): NumberFormatt
minimumFractionDigits,
lessThanMin ? 6 : getFiatNumberFractionDigits(number),
)
// Filter out undefined options caused by optional component props so they do not override the defaults
const filteredOptions = options
? Object.fromEntries(Object.entries(options).filter(([_, value]) => value !== undefined))
: {}
const formatter = new Intl.NumberFormat(deviceLocale, {
notation: number < bounds.min || noDecimals ? 'standard' : 'compact',
compactDisplay: fiatType || number < longCompactDisplayLowerBound ? 'short' : 'long',
style: fiatType ? 'currency' : 'decimal',
currency: fiatType,
minimumFractionDigits,
// Force enough fractional digits to truncate it properly without rounding off below
maximumFractionDigits: 10,
...options,
...filteredOptions,
})

const parts = formatter.formatToParts(formatNumber)
Expand Down