add 'objectProto' option to create parsed objects as {}#64
Open
egargan wants to merge 2 commits intosidorares:masterfrom
Open
add 'objectProto' option to create parsed objects as {}#64egargan wants to merge 2 commits intosidorares:masterfrom
egargan wants to merge 2 commits intosidorares:masterfrom
Conversation
This gives clients the ability to go back to the old behaviour before c85a430, where any parsed object was created as {}.
|
This PR seems really useful, is there any plan to merge it? |
|
I really need this functionality, else we need to wrap function with |
Author
|
I've emailed the owner but haven't heard anything back, we might be waiting a while! |
|
still hope merge it |
gleonid
approved these changes
Feb 5, 2025
Author
|
Thanks @btnkr! Let's go 🥳 |
Author
|
I don't have permissions to merge this by the way, so whoever does, please do! |
|
can you merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
This gives us the option of going back to the old object parsing behaviour, before c85a430, where any parsed object was created as {}.