Skip to content

Ensuring consistent elim behavior / vote inout calculation across import and normal paths - #184

Merged
sidprasad merged 3 commits into
mainfrom
fix
Jan 22, 2026
Merged

Ensuring consistent elim behavior / vote inout calculation across import and normal paths#184
sidprasad merged 3 commits into
mainfrom
fix

Conversation

@sidprasad

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fa58e7c05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pickController.ts Outdated
Comment on lines +708 to +710
} else {
// Candidate correctly does NOT match a rejected word - positive vote
candidate.positiveVotes++;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid adding positive votes for reject replays

In recalculateVotes, a rejected word that does not match now increments positiveVotes, but the normal classification path treats this case as neutral (no positive vote). As a result, any time vote history is replayed (e.g., refineCandidates or updateClassification), candidates can gain extra positives solely for rejecting words, changing selectBestCandidate and termination outcomes compared to the original session. This makes results depend on whether a recalculation occurred rather than the actual voting logic.

Useful? React with 👍 / 👎.

@sidprasad
sidprasad merged commit da12914 into main Jan 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant