Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fa58e7c05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| // Candidate correctly does NOT match a rejected word - positive vote | ||
| candidate.positiveVotes++; |
There was a problem hiding this comment.
Avoid adding positive votes for reject replays
In recalculateVotes, a rejected word that does not match now increments positiveVotes, but the normal classification path treats this case as neutral (no positive vote). As a result, any time vote history is replayed (e.g., refineCandidates or updateClassification), candidates can gain extra positives solely for rejecting words, changing selectBestCandidate and termination outcomes compared to the original session. This makes results depend on whether a recalculation occurred rather than the actual voting logic.
Useful? React with 👍 / 👎.
No description provided.