Skip to content

Ensuring consistent elim behavior / vote inout calculation across import and normal paths #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sidprasad merged 3 commits into from
Jan 22, 2026
Merged

Ensuring consistent elim behavior / vote inout calculation across import and normal paths #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72a7562
A fix
sidprasad Jan 22, 2026
9fa58e7
hotfix
sidprasad Jan 22, 2026
791af58
Another bugfix
sidprasad Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"publisher": "SiddharthaPrasad",
"icon": "images/icon.png",
"license": "MIT",
"version": "0.5.4",
"version": "0.5.5",
"repository": {
"type": "git",
"url": "https://github.com/sidprasad/pick-regex"
Expand Down
11 changes: 3 additions & 8 deletions src/pickController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,15 +682,12 @@ export class PickController {
for (const record of this.wordHistory) {
if (record.classification === WordClassification.ACCEPT) {
for (const candidate of this.candidates) {
if (candidate.eliminated) {
continue;
}
if (this.analyzer.verifyMatch(record.word, candidate.pattern)) {
candidate.positiveVotes++;
} else {
// Candidate fails to match an accepted word - negative vote
candidate.negativeVotes++;
if (candidate.negativeVotes >= candidate.eliminationThreshold) {
if (!candidate.eliminated && candidate.negativeVotes >= candidate.eliminationThreshold) {
candidate.eliminated = true;
logger.info(
`[Replay] Eliminated candidate "${candidate.pattern}" after ${candidate.negativeVotes} negative votes (threshold ${candidate.eliminationThreshold}) - failed to match accepted word "${record.word}".`
Expand All @@ -700,18 +697,16 @@ export class PickController {
}
} else if (record.classification === WordClassification.REJECT) {
for (const candidate of this.candidates) {
if (candidate.eliminated) {
continue;
}
if (this.analyzer.verifyMatch(record.word, candidate.pattern)) {
candidate.negativeVotes++;
if (candidate.negativeVotes >= candidate.eliminationThreshold) {
if (!candidate.eliminated && candidate.negativeVotes >= candidate.eliminationThreshold) {
candidate.eliminated = true;
logger.info(
`[Replay] Eliminated candidate "${candidate.pattern}" after ${candidate.negativeVotes} negative votes (threshold ${candidate.eliminationThreshold}) - incorrectly matched rejected word "${record.word}".`
);
}
}
// If doesn't match: no vote (correctly rejecting is neutral/expected)
}
}
}
Expand Down