Skip to content

549 Fixed six-file-upload-success being emitted twice on file drop in Ang…#550

Open
rspy wants to merge 1 commit into
mainfrom
fix/549-six-file-upload-zonejs-passive-listener
Open

549 Fixed six-file-upload-success being emitted twice on file drop in Ang…#550
rspy wants to merge 1 commit into
mainfrom
fix/549-six-file-upload-zonejs-passive-listener

Conversation

@rspy

@rspy rspy commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

…ular applications using Zone.js

🔗 Linked issue

Resolves #549

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Zone.js ignored the preventDefault on the vent listener because it was not marked as passive. This caused errors in the console and six-file-upload-success being emitted twice.

@github-actions

Copy link
Copy Markdown
Contributor

File Coverage
All files 92%
www/build/src/components/six-alert/six-alert.tsx 99%
www/build/src/components/six-breadcrumbs/six-breadcrumbs.tsx 83%
www/build/src/components/six-button/six-button.tsx 91%
www/build/src/components/six-checkbox/six-checkbox.tsx 93%
www/build/src/components/six-date/calendar-grid.ts 93%
www/build/src/components/six-date/six-date.tsx 96%
www/build/src/components/six-date/components/month-selection.tsx 90%
www/build/src/components/six-date/components/year-selection.tsx 91%
www/build/src/components/six-details/six-details.tsx 98%
www/build/src/components/six-dialog/six-dialog.tsx 98%
www/build/src/components/six-dropdown/six-dropdown.tsx 94%
www/build/src/components/six-error-page/six-error-page.tsx 91%
www/build/src/components/six-file-upload/six-file-upload.tsx 95%
www/build/src/components/six-group-label/six-group-label.tsx 83%
www/build/src/components/six-icon/six-icon.tsx 66%
www/build/src/components/six-icon-button/six-icon-button.tsx 90%
www/build/src/components/six-input/six-input.tsx 97%
www/build/src/components/six-item-picker/six-item-picker.tsx 99%
www/build/src/components/six-menu/six-menu.tsx 80%
www/build/src/components/six-menu-item/six-menu-item.tsx 99%
www/build/src/components/six-paginator/six-paginator.tsx 90%
www/build/src/components/six-picto/six-picto.tsx 66%
www/build/src/components/six-progress-ring/six-progress-ring.tsx 75%
www/build/src/components/six-range/six-range.tsx 92%
www/build/src/components/six-rating/six-rating.tsx 96%
www/build/src/components/six-search-field/six-search-field.tsx 90%
www/build/src/components/six-select/six-select.tsx 88%
www/build/src/components/six-select/util.ts 75%
www/build/src/components/six-sidebar/six-sidebar.tsx 92%
www/build/src/components/six-sidebar-item-group/six-sidebar-item-group.tsx 95%
www/build/src/components/six-switch/six-switch.tsx 95%
www/build/src/components/six-tab/six-tab.tsx 91%
www/build/src/components/six-tab-group/six-tab-group.tsx 78%
www/build/src/components/six-textarea/six-textarea.tsx 88%
www/build/src/components/six-tile/six-tile.tsx 83%
www/build/src/components/six-tooltip/six-tooltip.tsx 94%
www/build/src/functional-components/form-control/form-control.tsx 90%
www/build/src/utils/animation.ts 88%
www/build/src/utils/error-messages.ts 84%
www/build/src/utils/event-listeners.ts 91%
www/build/src/utils/execution-control.ts 90%
www/build/src/utils/focus-visible.ts 83%
www/build/src/utils/icon.ts 92%
www/build/src/utils/modal.ts 75%
www/build/src/utils/popover.ts 83%
www/build/src/utils/scroll.ts 87%
www/build/src/utils/slot.ts 90%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 55a7d25

@rspy
rspy requested review from colinscz and pennal July 16, 2026 14:10
@rspy
rspy marked this pull request as ready for review July 16, 2026 14:28
@rspy rspy changed the title Fixed six-file-upload-success being emitted twice on file drop in Ang… 549 Fixed six-file-upload-success being emitted twice on file drop in Ang… Jul 16, 2026

@colinscz colinscz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rspy please review the commit message before squashing :)
if it starts with "fix: " it will be easier to generate the release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

six-file-upload produces errors: Unable to preventDefault inside passive event listener invocation.

2 participants