Skip to content

549 Fixed six-file-upload-success being emitted twice on file drop in Ang… #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rspy wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −8
Open

549 Fixed six-file-upload-success being emitted twice on file drop in Ang… #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## Upcoming

### Fixed

- `six-file-upload`: Fixed six-file-upload-success being emitted twice on file drop in Angular
applications using Zone.js.

## 5.5.0 - 2026-07-03

- `six-breadcrumbs` new style aligned with design guidelines. Added `size` interface property.
Expand Down
16 changes: 8 additions & 8 deletions libraries/ui-library/src/components/six-file-upload/six-file-upload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,28 +68,28 @@ export class SixFileUpload {
/** Triggers when an uploaded file doesn't match MIME type or max file size. */
@Event({ eventName: 'six-file-upload-failure' }) failure!: EventEmitter<SixFileUploadFailurePayload>;

@Listen('dragenter', { capture: false })
@Listen('dragenter', { capture: false, passive: false })
dragenterHandler() {
if (!this.disabled) {
this.isOver = true;
}
}

@Listen('dragover', { capture: false })
@Listen('dragover', { capture: false, passive: false })
dragoverHandler() {
if (!this.disabled) {
this.isOver = true;
}
}

@Listen('dragleave', { capture: false })
@Listen('dragleave', { capture: false, passive: false })
dragleaveHandler() {
if (!this.disabled) {
this.isOver = false;
}
}

@Listen('drop', { capture: false })
@Listen('drop', { capture: false, passive: false })
dropHandler(event: DragEvent) {
if (!this.disabled) {
this.isOver = false;
Expand Down Expand Up @@ -157,16 +157,16 @@ export class SixFileUpload {

componentDidLoad() {
['dragenter', 'dragover', 'dragleave', 'drop'].forEach((eventName) => {
this.host.addEventListener(eventName, this.preventDefaults, false);
document.body.addEventListener(eventName, this.preventDefaults, false);
this.host.addEventListener(eventName, this.preventDefaults, { capture: false, passive: false });
document.body.addEventListener(eventName, this.preventDefaults, { capture: false, passive: false });
});
this.host.shadowRoot?.addEventListener('slotchange', this.handleSlotChange);
}

disconnectedCallback() {
['dragenter', 'dragover', 'dragleave', 'drop'].forEach((eventName) => {
this.host.removeEventListener(eventName, this.preventDefaults, false);
document.body.removeEventListener(eventName, this.preventDefaults, false);
this.host.removeEventListener(eventName, this.preventDefaults, { capture: false });
document.body.removeEventListener(eventName, this.preventDefaults, { capture: false });
});
this.host.shadowRoot?.removeEventListener('slotchange', this.handleSlotChange);
}
Expand Down
Loading