Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update charging logic to only update when engine is electric #659

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

WebSpider
Copy link
Contributor

Previously, any charging update received via MQTT would result in an update of the primary_engine always.
For Hybrid vehicles this may result in incorrect sensor updates, since the primary engine can be a combustion engine.

This PR fixes this by only updating charging information if the engine is an electric one.

Fixes #655

@WebSpider WebSpider added the bugfix This PR contains a bugfix label Mar 10, 2025
@WebSpider WebSpider requested review from dvx76 and prvakt March 10, 2025 11:10
@WebSpider WebSpider requested a review from dvx76 March 11, 2025 16:02
@WebSpider WebSpider merged commit 52a54c8 into skodaconnect:main Mar 12, 2025
3 checks passed
@WebSpider WebSpider deleted the fix-655 branch March 12, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR contains a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Estimated Fuel Range on Skoda Superb PHEV
2 participants