Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update charging logic to only update when engine is electric #659

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Update charging logic to only update when engine is electric #659

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be81e3d
Update charging logic to only update when engine is electric
WebSpider Mar 10, 2025
3ec8453
Prevent AttributeError when secondary_engine is absent
WebSpider Mar 10, 2025
f36ca40
Merge branch 'main' into fix-655
WebSpider Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions custom_components/myskoda/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
ServiceEvent,
ServiceEventTopic,
)
from myskoda.models.driving_range import EngineType
from myskoda.models.info import CapabilityId
from myskoda.models.operation_request import OperationName, OperationStatus
from myskoda.models.user import User
Expand Down Expand Up @@ -355,14 +356,27 @@ async def _on_charging_event(self, event: EventCharging):
if event_data.state:
status.state = event_data.state
if vehicle.driving_range:
per = vehicle.driving_range.primary_engine_range
ser = False

if vehicle.driving_range.secondary_engine_range:
ser = vehicle.driving_range.secondary_engine_range

if event_data.soc:
vehicle.driving_range.primary_engine_range.current_soc_in_percent = (
event_data.soc
)
if per.engine_type == EngineType.ELECTRIC:
per.current_soc_in_percent = event_data.soc
elif ser:
if ser.engine_type == EngineType.ELECTRIC:
ser.current_soc_in_percent = event_data.soc

if event_data.charged_range:
vehicle.driving_range.primary_engine_range.remaining_range_in_km = (
event_data.charged_range
)
range_in_km = int(event_data.charged_range / 1000)
if per.engine_type == EngineType.ELECTRIC:
per.remaining_range_in_km = range_in_km
elif ser:
if ser.engine_type == EngineType.ELECTRIC:
ser.remaining_range_in_km = range_in_km

some_charging_data_missing = (
event_data.charged_range is None
or event_data.soc is None
Expand Down