fix: include job_id in all failure paths of fit_predict_async#128
Open
Saloni-0465 wants to merge 1 commit into
Open
fix: include job_id in all failure paths of fit_predict_async#128Saloni-0465 wants to merge 1 commit into
Saloni-0465 wants to merge 1 commit into
Conversation
|
hi @Saloni-0465 i saw that you lint and pytests are failing this is due to problem in the main branch i have fixed both problem in my recent prs |
Contributor
Author
|
Got it @direkkakkar319-ops - I’ll rebase main once your CI fixes are in so this PR picks them up. |
4851560 to
da161e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None.
What does this implement/fix?
fit_predict_asyncnow always includesjob_idin the returned response across all paths:Previously, some early failure paths returned only an error dict without
job_id, even though the job had already been created. This made it impossible for clients to track or inspect failed async jobs.This change ensures consistency in the async job lifecycle - every response now includes
job_id.Does your contribution introduce a new dependency?
No.
What should a reviewer concentrate their feedback on?
Executor.fit_predict_asyncjob_idacross all execution pathsAny other comments?
None.
PR checklist
For all contributions
Title