Skip to content

fix: include job_id in all failure paths of fit_predict_async #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saloni-0465 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: include job_id in all failure paths of fit_predict_async #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sktime_mcp/runtime/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ async def fit_predict_async(
status=JobStatus.FAILED,
errors=[f"Failed to load dataset: {data_result.get('error')}"],
)
return data_result
return {**data_result, "job_id": job_id}

y = data_result["data"]
X = data_result.get("exog")
Expand All @@ -359,7 +359,7 @@ async def fit_predict_async(
status=JobStatus.FAILED,
errors=[f"Fit failed: {fit_result.get('error')}"],
)
return fit_result
return {**fit_result, "job_id": job_id}

# Step 3: Generate predictions
self._job_manager.update_job(
Expand All @@ -379,7 +379,7 @@ async def fit_predict_async(
status=JobStatus.FAILED,
errors=[f"Prediction failed: {predict_result.get('error')}"],
)
return predict_result
return {**predict_result, "job_id": job_id}

# Mark as completed
self._job_manager.update_job(
Expand All @@ -390,7 +390,7 @@ async def fit_predict_async(
result=predict_result,
)

return predict_result
return {**predict_result, "job_id": job_id}

except Exception as e:
logger.exception(f"Error in async fit_predict for job {job_id}")
Expand Down