Add print_output parameter to allow real time monitoring #30
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses something similar to #19.
The current behavior is that if return_output is True, nothing is printed to stdout as replication is occurring. Instead, the logs are returned once at the end.
return_output is True in the Dagster integration, so there is no progress written to stdout until the replication finishes. If something is taking a long time, we have no visibility into what step it is on.
With this PR, if return_output and print_output are both true, we will be able to see sling's progress in stdout in real time.
The if / else statements are a bit counterintuitive (e.g. if return_output and print_output are both false, it still prints), but I wrote it that way to make sure existing behavior doesn't change unless someone uses the new parameter intentionally.