Skip to content

Add print_output parameter to allow real time monitoring #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add print_output parameter to allow real time monitoring #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dac02a
Add print_output parameter
ben-wade-olo Mar 4, 2025
1909a2d
Keep existing behavior unchanged
ben-wade-olo Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sling/sling/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,9 +574,13 @@ def stream(self, env:dict=None, stdin=None) -> Iterable[list]:
# conform to legacy module
Sling = Task

def _run(cmd: str, temp_file: str, return_output=False, env:dict=None, stdin=None):
def _run(cmd: str, temp_file: str, return_output=False, print_output=False, env:dict=None, stdin=None):
"""
Runs the task. Use `return_output` as `True` to return the stdout+stderr output at end. `env` accepts a dictionary which defines the environment.
Runs the task.

Use `return_output` as `True` to return the stdout+stderr output at end.
Use `print_output` as `True` to print to stdout as it runs.
`env` accepts a dictionary which defines the environment.
"""
lines = []
try:
Expand All @@ -589,6 +593,8 @@ def _run(cmd: str, temp_file: str, return_output=False, env:dict=None, stdin=Non
lines.append(line)
else:
print(line, flush=True)
if print_output:
print(line, flush=True)

os.remove(temp_file)

Expand Down