Skip to content

fix: remove setting opacity with self keyword inside RNSVGNode #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2025
Merged

fix: remove setting opacity with self keyword inside RNSVGNode #2774

merged 3 commits into from
Sep 30, 2025

Conversation

kacperzolkiewski
Copy link
Collaborator

@kacperzolkiewski kacperzolkiewski commented Sep 17, 2025 •
edited
Loading

Summary

Remove setting variables inside RNSVGNode with self. and use underscore _ instead.

Test Plan

  • Example app -> TouchEvents
  • Create G with some Rect inside it and set opacity for G to 0 (Content inside G should be invisible)

Compatibility

OS Implemented
iOS ✅
MacOS ❌
Android ❌
Web ❌

Checklist

  • I have tested this on a device and a simulator

@kacperzolkiewski kacperzolkiewski changed the title fix: remove setting variables with self inside RNSVGNode fix: remove setting opacity with self keyword inside RNSVGNode Sep 17, 2025
@kacperzolkiewski kacperzolkiewski marked this pull request as ready for review September 17, 2025 10:33
@jakex7 jakex7 merged commit 2b4a348 into software-mansion:main Sep 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakex7 jakex7 jakex7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kacperzolkiewski @jakex7