Skip to content

fix: remove setting opacity with self keyword inside RNSVGNode #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2025
+3 −4
Merged

fix: remove setting opacity with self keyword inside RNSVGNode #2774

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29be1cb
fix: remove setting variables with self inside RNSVGNode
kacperzolkiewski Sep 17, 2025
4c16362
fix: restore matrix setting with self
kacperzolkiewski Sep 17, 2025
c1d8d0e
fix: add invmatrix setting with underscore
kacperzolkiewski Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions apple/RNSVGNode.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,12 @@ @implementation RNSVGNode {
- (instancetype)init
{
if (self = [super init]) {
self.opacity = 1;
#if !TARGET_OS_OSX // On macOS, views are transparent by default
self.opaque = false;
#endif
self.matrix = CGAffineTransformIdentity;
_matrix = CGAffineTransformIdentity;
_invmatrix = CGAffineTransformIdentity;
_opacity = 1;
_merging = false;
_dirty = false;
}
Expand Down Expand Up @@ -638,11 +639,9 @@ - (void)prepareForRecycle
{
[super prepareForRecycle];

self.opacity = 1;
#if !TARGET_OS_OSX // On macOS, views are transparent by default
self.opaque = false;
#endif
self.matrix = CGAffineTransformIdentity;
_merging = false;
_dirty = false;

Expand Down