This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Revert "Bump borsh from 0.10.3 to 0.11.0 (#31964)" #32145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 902d8b7.
CriesofCarrots
approved these changes
Jun 14, 2023
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Dang! Thanks for handling
joncinque
added
the
automerge
mergify
bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
joncinque
added
the
automerge
Contributor
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #32145 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 767 767
Lines 208961 208980 +19
=========================================
- Hits 171308 171297 -11
- Misses 37653 37683 +30 |
jeffwashington
pushed a commit
to HaoranYi/solana
that referenced
this pull request
Jun 15, 2023
…-labs#32145) This reverts commit 902d8b7.
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…-labs#32145) This reverts commit 902d8b7.
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…-labs#32145) This reverts commit 902d8b7.
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
…-labs#32145) This reverts commit 902d8b7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 902d8b7.
Problem
According to near/borsh-rs#146, version 0.11 was yanked because there's a security advisory fix coming out, and 0.11 changes the serialization format. When people update to the version with the security fix, they would get some incompatibility.
Summary of Changes
Until that's resolved, let's just revert the upgrade.
Fixes #