-
Notifications
You must be signed in to change notification settings - Fork 899
[Test plan][Smartswitch]Test plan for feature ENI Based Forwarding #19018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
@vivekrnv @oleksandrivantsiv @nhe-NV could you please review? |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Hi @roy-sror , we will have a test plan review for this on the next SmartSwitch Group Meeting(should be this week). |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
|
||
|
|
||
| ## Test | ||
| ### Test case # 1 – test_privatelink_basic_transform migrate to ENI based fowarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @congh-nvidia , after a second thought, we don't have to create a fixture/plugin for reusing the test cases. We can simply call the existing test functions for sending and validating the traffic. In this way, the top level test cases don't have to change, and also easy for future changes, say from DPU to ENI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @r12f , according to the design changed in sonic-net/SONiC#2081 and discussion we had with MSFT team, I have update the test plan and narrowed the test scope to only test on the NPU. The DPU dataplane interface is mocked by a NPU front panel interface.
In this case, we don't need consider the other existing dash tests and the functionality of this feature can be fully covered in this test.
Please review the test plan, the test is also ready, I will create the PR soon.
|
The PR is still in draft. Please change the state if it's ready for review&merge |
Update the test plan due to the design change.
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Update the test plan due to the design change: sonic-net/SONiC#2081
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
New test for the smartswitch feature ENI based forwarding. Test plan: sonic-net#19018
Description of PR
Summary:
This is the test plan for smartswitch feature ENI Based Forwarding.
Feature HLD:
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/high-availability/eni-based-forwarding.md
Test PR: #21251
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Only for smartswitch platforms.
Supported testbed topology if it's a new test case?
Documentation