Skip to content

Conversation

@congh-nvidia
Copy link
Contributor

@congh-nvidia congh-nvidia commented Jun 16, 2025

Description of PR

Summary:
This is the test plan for smartswitch feature ENI Based Forwarding.
Feature HLD:
https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/high-availability/eni-based-forwarding.md
Test PR: #21251

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Only for smartswitch platforms.

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@congh-nvidia
Copy link
Contributor Author

@vivekrnv @oleksandrivantsiv @nhe-NV could you please review?

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@roy-sror
Copy link
Contributor

@wangxin , @yxieca - can you pls help to review this change

@congh-nvidia
Copy link
Contributor Author

Hi @roy-sror , we will have a test plan review for this on the next SmartSwitch Group Meeting(should be this week).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@congh-nvidia congh-nvidia marked this pull request as draft July 18, 2025 04:27


## Test
### Test case # 1 – test_privatelink_basic_transform migrate to ENI based fowarding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @congh-nvidia , after a second thought, we don't have to create a fixture/plugin for reusing the test cases. We can simply call the existing test functions for sending and validating the traffic. In this way, the top level test cases don't have to change, and also easy for future changes, say from DPU to ENI.

Copy link
Contributor Author

@congh-nvidia congh-nvidia Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @r12f , according to the design changed in sonic-net/SONiC#2081 and discussion we had with MSFT team, I have update the test plan and narrowed the test scope to only test on the NPU. The DPU dataplane interface is mocked by a NPU front panel interface.
In this case, we don't need consider the other existing dash tests and the functionality of this feature can be fully covered in this test.
Please review the test plan, the test is also ready, I will create the PR soon.

@bingwang-ms
Copy link
Collaborator

The PR is still in draft. Please change the state if it's ready for review&merge

Update the test plan due to the design change.
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Update the test plan due to the design change: sonic-net/SONiC#2081
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@congh-nvidia congh-nvidia marked this pull request as ready for review November 10, 2025 10:47
congh-nvidia added a commit to congh-nvidia/sonic-mgmt that referenced this pull request Nov 10, 2025
New test for the smartswitch feature ENI based forwarding.
Test plan: sonic-net#19018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants