-
Notifications
You must be signed in to change notification settings - Fork 744
[portstat] Add FEC FLR statistics support to port counters #4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@apoorv-arista please fix the build errors Also, update the PR as per the HLD Can you put the link to the HLD in the PR description? |
@apoorv-arista please resolve the conflict |
- Add FEC_FLR and FEC_FLR_PREDICTED columns to fec-stats display - Implement format_fec_flr() function for displaying FLR values - Update RateStats namedtuple to include fec_flr fields - Update test expectations with new columns - Update documentation example with new FLR columns Signed-off-by: Apoorv Sachan <[email protected]>
2c5a16f
to
1be7162
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
cb42cfa
to
b4b8339
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
b4b8339
to
9277524
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
9277524
to
03feb87
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
resolved |
The PR and the code are now consistent with the HLD. @prgeor
|
Add support to view FEC FLR (Frame Loss Ratio) statistics in
port counter statistics.
This includes
can be verified by viewing fec-stats either by
portstat -f
orshow interfaces counters fec-stats
Feature HLD : port_fec_flr.md
What I did
Added FEC FLR (Frame Loss Ratio) statistics support to port counters display, including both actual and predicted FLR values.
How I did it
Added format_fec_flr() function to format FLR values consistently
Extended header_fec_only to include FEC_FLR and FEC_FLR_PREDICTED columns
Updated RateStats namedtuple to include fec_flr and fec_flr_predicted fields
Modified port statistics collection to retrieve FLR values from CHASSIS_STATE_DB
Updated display formatting to show FLR columns in fec-stats output
How to verify it
Run show interfaces counters fec-stats command and verify the output includes the new FEC_FLR and FEC_FLR_PREDICTED columns with properly formatted values.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)