Skip to content

docs(aac): initial updates to authorization docs #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

docs(aac): initial updates to authorization docs #852

merged 1 commit into from
Aug 14, 2025

Conversation

mwasilew2
Copy link
Contributor

Description of the change

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

@mwasilew2 mwasilew2 force-pushed the mwasilew2/aac-docs-update branch 7 times, most recently from 57ddead to 4a0e3a8 Compare August 6, 2025 08:29
@mwasilew2 mwasilew2 requested review from a team and KiraLempereur-Spacelift August 6, 2025 08:37
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
peterdeme
peterdeme reviewed Aug 6, 2025
View reviewed changes
@mwasilew2 mwasilew2 force-pushed the mwasilew2/aac-docs-update branch from cfec62b to 38fab55 Compare August 8, 2025 09:16
mwasilew2
mwasilew2 commented Aug 8, 2025
View reviewed changes
@mwasilew2 mwasilew2 marked this pull request as ready for review August 8, 2025 12:32
@mwasilew2 mwasilew2 force-pushed the mwasilew2/aac-docs-update branch from 8d40df6 to 9248d66 Compare August 8, 2025 12:37
KiraLempereur-Spacelift
KiraLempereur-Spacelift reviewed Aug 8, 2025
View reviewed changes
KiraLempereur-Spacelift
KiraLempereur-Spacelift reviewed Aug 8, 2025
View reviewed changes
KiraLempereur-Spacelift
KiraLempereur-Spacelift previously requested changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@KiraLempereur-Spacelift KiraLempereur-Spacelift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these are very good and contain all sorts of great information. Slight style changes throughout, marked where they are.

KNiepok
KNiepok approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@KNiepok KNiepok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mwasilew2 mwasilew2 force-pushed the mwasilew2/aac-docs-update branch from 0cfa034 to e4331da Compare August 12, 2025 08:18
@mwasilew2
Copy link
Contributor Author

rebased onto main

@mwasilew2 mwasilew2 force-pushed the mwasilew2/aac-docs-update branch from e4331da to 200fe83 Compare August 14, 2025 08:30
@mwasilew2
Copy link
Contributor Author

rebased onto main

@peterdeme
Copy link
Contributor

damn, failing on a new linter thing :/

@mwasilew2 mwasilew2 force-pushed the mwasilew2/aac-docs-update branch from 200fe83 to 6b24262 Compare August 14, 2025 10:22
@mwasilew2
Copy link
Contributor Author

rebased again

@mwasilew2 mwasilew2 force-pushed the mwasilew2/aac-docs-update branch from 6b24262 to 4c6fb45 Compare August 14, 2025 10:26
@mwasilew2 mwasilew2 dismissed KiraLempereur-Spacelift’s stale review August 14, 2025 10:26

addressed all comments and requested a re-review

@mwasilew2 mwasilew2 merged commit c16dff1 into main Aug 14, 2025
4 checks passed
@mwasilew2 mwasilew2 deleted the mwasilew2/aac-docs-update branch August 14, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KNiepok KNiepok KNiepok approved these changes

@peterdeme peterdeme peterdeme approved these changes

@KiraLempereur-Spacelift KiraLempereur-Spacelift Awaiting requested review from KiraLempereur-Spacelift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwasilew2 @peterdeme @KNiepok @KiraLempereur-Spacelift