This repository was archived by the owner on Dec 20, 2025. It is now read-only.
refactor(OAuth2): groovy to java conversion for OAuth module#1871
Merged
mergify[bot] merged 16 commits intospinnaker:masterfrom Feb 27, 2025
Merged
refactor(OAuth2): groovy to java conversion for OAuth module#1871mergify[bot] merged 16 commits intospinnaker:masterfrom
mergify[bot] merged 16 commits intospinnaker:masterfrom
Conversation
rahul-chekuri
force-pushed
the
oauth-groovy-java
branch
from
c14fa61 to
6417b15
Compare
dbyron-sf
reviewed
Feb 17, 2025
...oauth2/src/main/java/com/netflix/spinnaker/gate/security/oauth2/ExternalAuthTokenFilter.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 17, 2025
...oauth2/src/main/java/com/netflix/spinnaker/gate/security/oauth2/ExternalAuthTokenFilter.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 17, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 17, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 17, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 17, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 18, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 18, 2025
...main/groovy/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 18, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 18, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 18, 2025
...h2/src/test/java/com/netflix/spinnaker/gate/security/oauth2/ExternalAuthTokenFilterTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 18, 2025
gate-web/src/test/java/com/netflix/spinnaker/gate/security/oauth/OAuth2Test.java
Show resolved
Hide resolved
rahul-chekuri
force-pushed
the
oauth-groovy-java
branch
from
6417b15 to
f43c17e
Compare
rahul-chekuri
force-pushed
the
oauth-groovy-java
branch
from
f43c17e to
509d221
Compare
dbyron-sf
reviewed
Feb 19, 2025
...oauth2/src/main/java/com/netflix/spinnaker/gate/security/oauth2/ExternalAuthTokenFilter.java
Outdated
Show resolved
Hide resolved
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
rahul-chekuri
force-pushed
the
oauth-groovy-java
branch
from
3b0e59c to
aac890f
Compare
Validated and tested using google and github OAuth.
…e input is null. Add javadoc
rahul-chekuri
force-pushed
the
oauth-groovy-java
branch
from
aac890f to
b731f90
Compare
dbyron-sf
reviewed
Feb 22, 2025
...test/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServicesTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 22, 2025
...test/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServicesTest.java
Show resolved
Hide resolved
- Replaced member injection with constructor injection - Improved encapsulation by removing direct member access - Updated tests to pass dependencies via constructor
dbyron-sf
reviewed
Feb 26, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Feb 26, 2025
...test/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServicesTest.java
Outdated
Show resolved
Hide resolved
- Removed annotations from individual members - Added to the all-args constructor - Removed no-arg constructor to enforce dependency injection - Improved clarity and testability of the class
dbyron-sf
reviewed
Feb 26, 2025
...src/main/java/com/netflix/spinnaker/gate/security/oauth2/SpinnakerUserInfoTokenServices.java
Outdated
Show resolved
Hide resolved
…it optional using Optional<SpinnakerProviderTokenServices>
dbyron-sf
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validated and tested using google and github OAuth.