Skip to content
This repository was archived by the owner on Dec 20, 2025. It is now read-only.

refactor(OAuth2): groovy to java conversion for OAuth module #1871

Merged
mergify merged 16 commits into from
Feb 27, 2025
Merged

refactor(OAuth2): groovy to java conversion for OAuth module #1871

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
28c3f1b
refactor(OAuth2): groovy to java conversion for OAuth module
rahul-chekuri Feb 17, 2025
c23d0f0
Add specific imports and remove *
rahul-chekuri Feb 19, 2025
b8a4bec
Remove DefaultGroovyMethods
rahul-chekuri Feb 19, 2025
6112cb0
Add StructuredArguments.entries
rahul-chekuri Feb 19, 2025
3a99dfc
Rename safeGet to toStringOrNull. toStringOrNull returns null when th…
rahul-chekuri Feb 19, 2025
a4877c7
Replace details.getOrDefault with Optional to handle null cases
rahul-chekuri Feb 19, 2025
6e3b2d3
Add log statement from groovy code
rahul-chekuri Feb 19, 2025
83fca4a
Use AssertJ
rahul-chekuri Feb 19, 2025
d00a637
First checks log.isDebugEnabled() to avoid unnecessary String concate…
rahul-chekuri Feb 20, 2025
88835b6
Add non empty string check
rahul-chekuri Feb 20, 2025
b731f90
Add test for SpinnakerUserInfoTokenServices#isServiceAccount
rahul-chekuri Feb 21, 2025
418b4f2
Refactor SpinnakerUserInfoTokenServices to use constructor injection
rahul-chekuri Feb 26, 2025
254e974
Preserve method call verifications in tests
rahul-chekuri Feb 26, 2025
4f2fe71
Refactor to use constructor injection
rahul-chekuri Feb 26, 2025
ea49da5
Add specific imports and remove *
rahul-chekuri Feb 26, 2025
cde948b
Move SpinnakerProviderTokenServices to constructor argument and make …
rahul-chekuri Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gate-oauth2/gate-oauth2.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ dependencies {
implementation project(":gate-core")
implementation "com.netflix.spectator:spectator-api"
implementation "io.spinnaker.fiat:fiat-api:$fiatVersion"
implementation "io.spinnaker.fiat:fiat-core:$fiatVersion"
implementation "io.spinnaker.kork:kork-exceptions"
implementation "io.spinnaker.kork:kork-retrofit"
implementation "io.spinnaker.kork:kork-security"
Expand Down
73 changes: 0 additions & 73 deletions ...src/main/groovy/com/netflix/spinnaker/gate/security/oauth2/ExternalAuthTokenFilter.groovy
View file
Open in desktop

This file was deleted.

130 changes: 0 additions & 130 deletions ...-oauth2/src/main/groovy/com/netflix/spinnaker/gate/security/oauth2/OAuth2SsoConfig.groovy
View file
Open in desktop

This file was deleted.

Loading