Support dynamic paths in route URI using SetRequestUri filter#3761
Merged
ryanjbaxter merged 6 commits intospring-cloud:mainfrom May 22, 2025
Merged
Support dynamic paths in route URI using SetRequestUri filter#3761ryanjbaxter merged 6 commits intospring-cloud:mainfrom
ryanjbaxter merged 6 commits intospring-cloud:mainfrom
Conversation
Signed-off-by: Stepan Mikhailiuk <[email protected]>
Contributor
Author
|
@spencergibb, sorry, I didn't figure out how to request review, expected automatic PR assign. |
ryanjbaxter
reviewed
May 13, 2025
| String url = getUri(exchange, config); | ||
| URI uri = URI.create(url); | ||
| if (!uri.isAbsolute()) { | ||
| throw new IllegalArgumentException("URI is not absolute"); |
Contributor
There was a problem hiding this comment.
Why throw then catch this exception only to return Optional.ofNullable(null)? Couldn't you just call log.info and then return here?
Contributor
Author
There was a problem hiding this comment.
@ryanjbaxter , yeah, you are right! fixed, thank you!
Signed-off-by: Stepan Mikhailiuk <[email protected]>
Signed-off-by: Stepan Mikhailiuk <[email protected]>
Contributor
|
Can you take a look at the CI build? |
Signed-off-by: Stepan Mikhailiuk <[email protected]>
Contributor
Author
|
@ryanjbaxter , thank you, updated test, AFAIK I can't trigger the CI build myself to check everything correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Spring Cloud Gateway does not support dynamic path segments directly in the uri field of a route. This limitation makes it challenging to forward requests to upstream services whose hostnames or paths depend on request parameters (e.g. a path variable like {appId}).
What’s Changed
This PR introduces an update to the routing configuration that leverages the SetRequestUri GatewayFilter factory to dynamically construct the request URI based on path variables. By using URI templates supported by Spring Framework, we can now rewrite the request URI at runtime with values extracted from the incoming request path.
Example Configuration
For a request path of
/red-application/blue, this sets the uri tohttp://red-application.internal.combefore making the downstream request and the final url, including path is going to behttp://red-application.indernal.com/red-application/blueAdditional notes
This filter is similar to
RequestHeaderToRequestUriGatewayFilterFactory but more generic