-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Support dynamic paths in route URI using SetRequestUri filter #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c6ed845
feat(gateway-filter): add SetRequestUri gateway filter
stepancar 7b4dd7c
fix(*): remove unnecessary exception according review comments
stepancar f5076c4
fix(*): remove unnecessary exception according review comments
stepancar cf8c1eb
Merge branch 'spring-cloud:main' into setrequesturi
stepancar 4fdf22e
fix(*): fix disable builtin filter
stepancar c9df303
Merge branch 'main' into pr/3761
ryanjbaxter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
...spring-cloud-gateway-server-webflux/gatewayfilter-factories/seturi-factory.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| [[seturi-gatewayfilter-factory]] | ||
| = `SetRequestUri` `GatewayFilter` Factory | ||
|
|
||
| The `SetRequestUri` `GatewayFilter` factory takes a `uri` parameter. | ||
| It offers a simple way to manipulate the request uri by allowing templated segments of the path. | ||
| This uses the URI templates from Spring Framework. | ||
| Multiple matching segments are allowed. | ||
| The following listing configures a `SetRequestUri` `GatewayFilter`: | ||
|
|
||
| .application.yml | ||
| [source,yaml] | ||
| ---- | ||
| spring: | ||
| cloud: | ||
| gateway: | ||
| routes: | ||
| - id: seturi_route | ||
| uri: no://op | ||
| predicates: | ||
| - Path=/{appId}/** | ||
| filters: | ||
| - SetRequestUri=http://{appId}.example.com | ||
| ---- | ||
|
|
||
| For a request path of `/red-application/blue`, this sets the uri to `http://red-application.example.com` before making the downstream request and the final url, including path is going to be `http://red-application.example.com/red-application/blue` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
...a/org/springframework/cloud/gateway/filter/factory/SetRequestUriGatewayFilterFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /* | ||
| * Copyright 2013-2020 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.cloud.gateway.filter.factory; | ||
|
|
||
| import java.net.URI; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import org.springframework.cloud.gateway.filter.GatewayFilter; | ||
| import org.springframework.cloud.gateway.filter.OrderedGatewayFilter; | ||
| import org.springframework.web.server.ServerWebExchange; | ||
| import org.springframework.web.util.UriComponentsBuilder; | ||
|
|
||
| import static org.springframework.cloud.gateway.support.GatewayToStringStyler.filterToStringCreator; | ||
| import static org.springframework.cloud.gateway.support.ServerWebExchangeUtils.getUriTemplateVariables; | ||
|
|
||
| /** | ||
| * This filter changes the request uri. | ||
| * | ||
| * @author Stepan Mikhailiuk | ||
| */ | ||
| public class SetRequestUriGatewayFilterFactory | ||
| extends AbstractChangeRequestUriGatewayFilterFactory<SetRequestUriGatewayFilterFactory.Config> { | ||
|
|
||
| private static final Logger log = LoggerFactory.getLogger(SetRequestUriGatewayFilterFactory.class); | ||
|
|
||
| public SetRequestUriGatewayFilterFactory() { | ||
| super(Config.class); | ||
| } | ||
|
|
||
| @Override | ||
| public List<String> shortcutFieldOrder() { | ||
| return Arrays.asList(NAME_KEY); | ||
| } | ||
|
|
||
| @Override | ||
| public GatewayFilter apply(Config config) { | ||
| // AbstractChangeRequestUriGatewayFilterFactory.apply() returns | ||
| // OrderedGatewayFilter | ||
| OrderedGatewayFilter gatewayFilter = (OrderedGatewayFilter) super.apply(config); | ||
| return new OrderedGatewayFilter(gatewayFilter, gatewayFilter.getOrder()) { | ||
| @Override | ||
| public String toString() { | ||
| return filterToStringCreator(SetRequestUriGatewayFilterFactory.this) | ||
| .append("template", config.getTemplate()) | ||
| .toString(); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| String getUri(ServerWebExchange exchange, Config config) { | ||
| String template = config.getTemplate(); | ||
|
|
||
| if (template.indexOf('{') == -1) { | ||
| return template; | ||
| } | ||
|
|
||
| Map<String, String> variables = getUriTemplateVariables(exchange); | ||
| return UriComponentsBuilder.fromUriString(template).build().expand(variables).toUriString(); | ||
| } | ||
|
|
||
| @Override | ||
| protected Optional<URI> determineRequestUri(ServerWebExchange exchange, Config config) { | ||
| try { | ||
| String url = getUri(exchange, config); | ||
| URI uri = URI.create(url); | ||
| if (!uri.isAbsolute()) { | ||
| throw new IllegalArgumentException("URI is not absolute"); | ||
| } | ||
| return Optional.of(uri); | ||
| } | ||
| catch (IllegalArgumentException e) { | ||
|
|
||
| log.info("Request url is invalid : url={}, error={}", config.getTemplate(), e.getMessage()); | ||
| return Optional.ofNullable(null); | ||
| } | ||
| } | ||
|
|
||
| public static class Config { | ||
|
|
||
| private String template; | ||
|
|
||
| public String getTemplate() { | ||
| return template; | ||
| } | ||
|
|
||
| public void setTemplate(String template) { | ||
| this.template = template; | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
...ework/cloud/gateway/filter/factory/SetRequestUriGatewayFilterFactoryIntegrationTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright 2013-2020 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.cloud.gateway.filter.factory; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import org.springframework.boot.SpringBootConfiguration; | ||
| import org.springframework.boot.autoconfigure.EnableAutoConfiguration; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
| import org.springframework.boot.test.web.server.LocalServerPort; | ||
| import org.springframework.cloud.gateway.route.RouteLocator; | ||
| import org.springframework.cloud.gateway.route.builder.RouteLocatorBuilder; | ||
| import org.springframework.cloud.gateway.test.BaseWebClientTests; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Import; | ||
| import org.springframework.test.annotation.DirtiesContext; | ||
|
|
||
| import static org.springframework.boot.test.context.SpringBootTest.WebEnvironment.RANDOM_PORT; | ||
|
|
||
| /** | ||
| * @author Stepan Mikhailiuk | ||
| */ | ||
| @SpringBootTest(webEnvironment = RANDOM_PORT) | ||
| @DirtiesContext | ||
| public class SetRequestUriGatewayFilterFactoryIntegrationTests extends BaseWebClientTests { | ||
|
|
||
| @LocalServerPort | ||
| int port; | ||
|
|
||
| @Test | ||
| public void setUriWorkWithProperties() { | ||
| testClient.get().uri("/").header("Host", "testservice.setrequesturi.org").exchange().expectStatus().isOk(); | ||
|
|
||
| testClient.get() | ||
| .uri("/service/testservice") | ||
| .header("Host", "setrequesturi.org") | ||
| .exchange() | ||
| .expectStatus() | ||
| .isOk(); | ||
| } | ||
|
|
||
| @EnableAutoConfiguration | ||
| @SpringBootConfiguration | ||
| @Import(DefaultTestConfig.class) | ||
| public static class TestConfig { | ||
|
|
||
| @Bean | ||
| public RouteLocator routeLocator(RouteLocatorBuilder builder) { | ||
| return builder.routes() | ||
| .route("map_subdomain_to_service_name", | ||
| r -> r.host("{serviceName}.setrequesturi.org") | ||
| .filters(f -> f.prefixPath("/httpbin").setRequestUri("lb://{serviceName}")) | ||
| .uri("no://op")) | ||
| .route("map_path_to_service_name", | ||
| r -> r.host("setrequesturi.org") | ||
| .and() | ||
| .path("/service/{serviceName}") | ||
| .filters(f -> f.rewritePath("/.*", "/").setRequestUri("lb://{serviceName}")) | ||
| .uri("no://op")) | ||
| .build(); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } |
83 changes: 83 additions & 0 deletions
83
.../springframework/cloud/gateway/filter/factory/SetRequestUriGatewayFilterFactoryTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Copyright 2013-2020 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.cloud.gateway.filter.factory; | ||
|
|
||
| import java.net.URI; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.ArgumentCaptor; | ||
| import reactor.core.publisher.Mono; | ||
|
|
||
| import org.springframework.cloud.gateway.filter.GatewayFilter; | ||
| import org.springframework.cloud.gateway.filter.GatewayFilterChain; | ||
| import org.springframework.mock.http.server.reactive.MockServerHttpRequest; | ||
| import org.springframework.mock.web.server.MockServerWebExchange; | ||
| import org.springframework.web.server.ServerWebExchange; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.springframework.cloud.gateway.support.ServerWebExchangeUtils.GATEWAY_REQUEST_URL_ATTR; | ||
|
|
||
| /** | ||
| * @author Stepan Mikhailiuk | ||
| */ | ||
| public class SetRequestUriGatewayFilterFactoryTests { | ||
|
|
||
| @Test | ||
| public void filterChangeRequestUri() { | ||
| SetRequestUriGatewayFilterFactory factory = new SetRequestUriGatewayFilterFactory(); | ||
| GatewayFilter filter = factory.apply(c -> c.setTemplate("https://example.com")); | ||
| MockServerHttpRequest request = MockServerHttpRequest.get("http://localhost").build(); | ||
| ServerWebExchange exchange = MockServerWebExchange.from(request); | ||
| exchange.getAttributes().put(GATEWAY_REQUEST_URL_ATTR, URI.create("http://localhost")); | ||
| GatewayFilterChain filterChain = mock(GatewayFilterChain.class); | ||
| ArgumentCaptor<ServerWebExchange> captor = ArgumentCaptor.forClass(ServerWebExchange.class); | ||
| when(filterChain.filter(captor.capture())).thenReturn(Mono.empty()); | ||
| filter.filter(exchange, filterChain); | ||
| ServerWebExchange webExchange = captor.getValue(); | ||
| URI uri = (URI) webExchange.getAttributes().get(GATEWAY_REQUEST_URL_ATTR); | ||
| assertThat(uri).isNotNull(); | ||
| assertThat(uri.toString()).isEqualTo("https://example.com"); | ||
| } | ||
|
|
||
| @Test | ||
| public void filterDoesNotChangeRequestUriIfUriIsInvalid() throws Exception { | ||
| SetRequestUriGatewayFilterFactory factory = new SetRequestUriGatewayFilterFactory(); | ||
| GatewayFilter filter = factory.apply(c -> c.setTemplate("invalid_uri")); | ||
| MockServerHttpRequest request = MockServerHttpRequest.get("http://localhost").build(); | ||
| ServerWebExchange exchange = MockServerWebExchange.from(request); | ||
| exchange.getAttributes().put(GATEWAY_REQUEST_URL_ATTR, URI.create("http://localhost")); | ||
| GatewayFilterChain filterChain = mock(GatewayFilterChain.class); | ||
| ArgumentCaptor<ServerWebExchange> captor = ArgumentCaptor.forClass(ServerWebExchange.class); | ||
| when(filterChain.filter(captor.capture())).thenReturn(Mono.empty()); | ||
| filter.filter(exchange, filterChain); | ||
| ServerWebExchange webExchange = captor.getValue(); | ||
| URI uri = (URI) webExchange.getAttributes().get(GATEWAY_REQUEST_URL_ATTR); | ||
| assertThat(uri).isNotNull(); | ||
| assertThat(uri.toURL().toString()).isEqualTo("http://localhost"); | ||
| } | ||
|
|
||
| @Test | ||
| public void toStringFormat() { | ||
| SetRequestUriGatewayFilterFactory.Config config = new SetRequestUriGatewayFilterFactory.Config(); | ||
| config.setTemplate("http://localhost:8080"); | ||
| GatewayFilter filter = new SetRequestUriGatewayFilterFactory().apply(config); | ||
| assertThat(filter.toString()).contains("http://localhost:8080"); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why throw then catch this exception only to return
Optional.ofNullable(null)? Couldn't you just calllog.infoand then return here?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanjbaxter , yeah, you are right! fixed, thank you!