Skip to content

ROX-29116: Use ARM GH action workflow runners for ARM builds #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 25, 2025

Conversation

robbycochran
Copy link
Collaborator

@robbycochran robbycochran commented Apr 14, 2025

Description

Utilize newly added arm64 runners for github actions.

  • Build arm64 images natively instead of using QEMU in all workflows
  • Make arm64 builds, unit-tests, and integration tests run alongside x86_64 by default on PR workflows. Build time performance is slightly faster on ARM so it shouldn't increase total time to finish PR steps.
  • Split and refactored the builder image job into a local and remote version

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added integration tests

If any of these don't apply, please comment below.

Testing Performed

@robbycochran robbycochran added the run-multiarch-builds Run steps for non-x86 archs. label Apr 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.40%. Comparing base (3106b4b) to head (216401d).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2084      +/-   ##
==========================================
+ Coverage   27.53%   28.40%   +0.87%     
==========================================
  Files          93       94       +1     
  Lines        5724     5717       -7     
  Branches     2532     2531       -1     
==========================================
+ Hits         1576     1624      +48     
+ Misses       3481     3383      -98     
- Partials      667      710      +43     
Flag Coverage Δ
collector-unit-tests 28.40% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbycochran robbycochran removed the run-multiarch-builds Run steps for non-x86 archs. label Apr 14, 2025
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arm image builds in 6 minutes 😻

@robbycochran robbycochran force-pushed the rc-gh-action-arm branch 2 times, most recently from 87da314 to 1179d57 Compare April 18, 2025 18:17
@robbycochran robbycochran marked this pull request as ready for review April 18, 2025 18:57
@robbycochran robbycochran requested a review from a team as a code owner April 18, 2025 18:57
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robbycochran - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using matrix.set instead of environment variables and github-script to pass the list of architectures to the manifest creation steps.
  • The conditional logic for s390x in the builder image job seems overly complex and could be simplified.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

1179d57 Squash
835342e rn
8430368 update
f54326c unit
e9fc780 merge builder
9515346 split
d7b2d89 workflow
19f9fc9 update
f220584 always
1af882d unit
6a5d9a7 comment
a22a493 unit
9424110 unit
83bb60f enable builder
4c01e09 arch
4f0df21 clean
d07cefc arch
50aec13c9 typo
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments on the runner version, but other than that LGTM!

Thanks for putting the effort into this, it simplifies a lot of code in our CI and it'll be great to have arm built and tested on all PRs!

@robbycochran robbycochran merged commit d562819 into master Apr 25, 2025
79 of 83 checks passed
@robbycochran robbycochran deleted the rc-gh-action-arm branch April 25, 2025 17:31
robbycochran added a commit that referenced this pull request Apr 26, 2025
@robbycochran robbycochran mentioned this pull request Apr 26, 2025
5 tasks
@robbycochran robbycochran restored the rc-gh-action-arm branch April 28, 2025 20:44
@robbycochran robbycochran changed the title Use ARM GH action workflow runners for ARM builds ROX-29116: Use ARM GH action workflow runners for ARM builds Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants