-
Notifications
You must be signed in to change notification settings - Fork 25
ROX-29116: Use ARM GH action workflow runners for ARM builds #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5ea2d78
to
dfe1293
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2084 +/- ##
==========================================
+ Coverage 27.53% 28.40% +0.87%
==========================================
Files 93 94 +1
Lines 5724 5717 -7
Branches 2532 2531 -1
==========================================
+ Hits 1576 1624 +48
+ Misses 3481 3383 -98
- Partials 667 710 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7474f22
to
e6f371e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arm image builds in 6 minutes 😻
87da314
to
1179d57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @robbycochran - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
matrix.set
instead of environment variables and github-script to pass the list of architectures to the manifest creation steps. - The conditional logic for
s390x
in the builder image job seems overly complex and could be simplified.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
d07cefc
to
97d0158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments on the runner version, but other than that LGTM!
Thanks for putting the effort into this, it simplifies a lot of code in our CI and it'll be great to have arm built and tested on all PRs!
This reverts commit d562819.
Description
Utilize newly added arm64 runners for github actions.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
run-multiarch-builds
label -> [testing] branch rc-gh-action-arm on multiarch label #2094