Allow specifying URL for GDPS #49

yuptune · 2025-01-11T11:37:34Z

_This is exactly like the one before, but with needed changes that were put in here.

Please note that I don't even know what I'm doing. So if this is wrong, PLEASE correct me. It would be highly appreciated._

Thanks,
yuptune 👍

…o edit URLs for GDPSes The const was changed to a static of type ``OnceCell<&'static str>``. ``get_gd_url`` is now a call to ``OnceCell::get_or_init``, and the "or init" part is also set to the boomlings servers. (This is changeable, by the way. ;)). Also, i don't even know what i'm doing. So if i'm wrong please correct the mistakes i made in this commit. Hope this helps, yuptune

yuptune · 2025-01-11T11:37:57Z

I just realized I put the note for the PR inside of the commit. Silly me

stadust

Thanks! Please drop all the unrelated deletion of comments/module declarations (I guess those are from testing?).

Also, now that dash-rs is gaining this feature, maybe we should add a quick note in the readme telling people how to use this? (explicitly setting the OnceLock from fn main)

stadust · 2025-01-11T13:18:56Z

src/request/mod.rs

-macro_rules! const_setter {
-    ($name: ident, $field: ident, $t: ty) => {
-        pub const fn $name(mut self, $field: $t) -> Self {
-            self.$field = $field;
-            self
-        }
-    };
-
-    ($name: ident, $t: ty) => {
-        pub const fn $name(mut self, arg0: $t) -> Self {
-            self.$name = arg0;
-            self
-        }
-    };
+static GDPS_URL: OnceCell<String> = OnceCell::new();

-    ($(#[$attr:meta])* $name: ident: $t: ty) => {
-        $(#[$attr])*
-        pub const fn $name(mut self, $name: $t) -> Self {
-            self.$name = $name;
-            self
-        }
-    };
-
-    ($(#[$attr:meta])* $field:ident[$name: ident]: $t: ty) => {
-        $(#[$attr])*
-        pub const fn $name(mut self, $field: $t) -> Self {
-            self.$field = $field;
-            self
-        }
-    }


I think you accidentally deleted a bit more than intended :D

the commit says its outdated for some reason. i don't know why.

Mh, seems like now these are moved to the end of the file. Can you move them back?

stadust · 2025-01-11T13:19:26Z

src/request/mod.rs

-pub mod level;
-pub mod user;
-
-pub const REQUEST_BASE_URL: &str = "https://www.boomlings.com/database/";


Mh, maybe let's keep this constant, but rename it BOOMLINGS_REQUEST_BASE

src/request/mod.rs

stadust · 2025-01-11T13:25:39Z

src/request/mod.rs

-            self
-        }
-    };
+static GDPS_URL: OnceCell<String> = OnceCell::new();


this needs to be a pub static, so that code using dash-rs can set the OnceCell in their initialization code.

Also, let's name it REQUEST_BASE, because it doesn't have to be a GDPS URL (and in the most common usecase of interacting with the boomlings servers, it actually won't be a GDPS URL).

I also realized that this needs to be a OnceLock and not a OnceCell for use in statics. Sorry! So altogether, this should be

Suggested change

static GDPS_URL: OnceCell<String> = OnceCell::new();

pub static REQUEST_BASE: OnceLock<&'static str> = OnceLock::new();

src/request/mod.rs

stadust · 2025-01-11T13:27:44Z

Btw, you can reuse PRs by just pushing to the branch from which you originally opened the PR. GitHub will automatically update the PR, so you don't have to open a new one :)

yuptune · 2025-01-11T13:36:47Z

Alright, thanks :P

Co-authored-by: Patrick <[email protected]>

yuptune · 2025-01-11T14:05:39Z

Alright, i think i fixed all of the issues you listed.

yuptune · 2025-01-11T15:09:15Z

stadust

Thanks for fixing all those typos!

I unresolved some of the older reviews that don't seem fixed. Maybe you forgot to push something? :o

stadust · 2025-01-11T17:36:14Z

README.md

+`rust
+GDPS_URL.get_or_init(|| "https://your-custom-gdps-url.com".to_string());`


Suggested change

`rust

GDPS_URL.get_or_init(|| "https://your-custom-gdps-url.com".to_string());`

```rust

REQUEST_BASE.get_or_init(|| "https://your-custom-gdps-url.com");`

\```

in your `fn main` (or anywhere before the first call to any dash-rs functions)

(without the backslack at the end, turns out putting backticks into codeblocks is quite hard haha)

stadust · 2025-01-11T17:37:47Z

src/request/mod.rs

-macro_rules! const_setter {
-    ($name: ident, $field: ident, $t: ty) => {
-        pub const fn $name(mut self, $field: $t) -> Self {
-            self.$field = $field;
-            self
-        }
-    };
-
-    ($name: ident, $t: ty) => {
-        pub const fn $name(mut self, arg0: $t) -> Self {
-            self.$name = arg0;
-            self
-        }
-    };
+static GDPS_URL: OnceCell<String> = OnceCell::new();

-    ($(#[$attr:meta])* $name: ident: $t: ty) => {
-        $(#[$attr])*
-        pub const fn $name(mut self, $name: $t) -> Self {
-            self.$name = $name;
-            self
-        }
-    };
-
-    ($(#[$attr:meta])* $field:ident[$name: ident]: $t: ty) => {
-        $(#[$attr])*
-        pub const fn $name(mut self, $field: $t) -> Self {
-            self.$field = $field;
-            self
-        }
-    }


Mh, seems like now these are moved to the end of the file. Can you move them back?

stadust · 2025-01-11T17:38:08Z

src/request/mod.rs

-pub mod comment;
-pub mod level;
-pub mod user;


These module declarations still seem to be deleted :(

stadust · 2025-01-11T17:39:20Z

src/request/mod.rs

-            self
-        }
-    }
+pub fn get_gdps_url() -> String {


Let's also rename this function to something like fn base_request_url()

stadust · 2025-01-11T17:39:43Z

README.md

@@ -7,6 +7,11 @@

 The project is a collaboration with [mgostIH](https://github.com/mgostIH), on whose idea the initial library design is based on and who continues to provide incredibly helpful insights into optimization, Geometry Dash and Rust.

+## Guide


Suggested change

## Guide

## Using dash-rs with a GDPS

stadust · 2025-01-11T17:40:11Z

README.md

@@ -7,6 +7,11 @@

 The project is a collaboration with [mgostIH](https://github.com/mgostIH), on whose idea the initial library design is based on and who continues to provide incredibly helpful insights into optimization, Geometry Dash and Rust.

+## Guide
+If you are planning to use this for your own demonlist that isn't related to the main Geometry Dash servers, you can use:


Suggested change

If you are planning to use this for your own demonlist that isn't related to the main Geometry Dash servers, you can use:

If you are planning to use this library for interacting with a GDPS, you can use:

stadust · 2025-01-13T21:31:38Z

Heya, I've done the final fixups locally and squashed everything into ee5919e, which I pushed to master. GitHub won't notice that it's a manual merge, so won't mark this as "merged", but everything is definitely in the master branch now!

Thanks for your contribution!

LG125YT · 2025-01-13T21:54:48Z

Ah, it seems i was too late! (I had just finished doing my own fixes and i just committed to the fork repo)

Well, thanks for the review and work anyways!

LG125YT and others added 3 commits January 10, 2025 14:48

add support for custom GDPS's

aacd06e

revert changes in directory

ebbe84a

yuptune mentioned this pull request Jan 11, 2025

add support for other GD related servers (including GDPSes) #48

Closed

stadust reviewed Jan 11, 2025

View reviewed changes

yuptune and others added 4 commits January 11, 2025 08:43

Update src/request/mod.rs

edf9257

Co-authored-by: Patrick <[email protected]>

Update src/request/mod.rs

7bc63bc

Co-authored-by: Patrick <[email protected]>

Update README.md

6762be7

Update mod.rs

3da6f7c

stadust changed the title ~~New PR. :)~~ Allow specifying URL for GDPS Jan 11, 2025

stadust reviewed Jan 11, 2025

View reviewed changes

fixes suggested by stadust

b98116a

stadust closed this Jan 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow specifying URL for GDPS #49

Allow specifying URL for GDPS #49

yuptune commented Jan 11, 2025

yuptune commented Jan 11, 2025

stadust left a comment

stadust Jan 11, 2025

yuptune Jan 11, 2025

stadust Jan 11, 2025

stadust Jan 11, 2025

stadust Jan 11, 2025 •

edited

Loading

stadust commented Jan 11, 2025

yuptune commented Jan 11, 2025

yuptune commented Jan 11, 2025

yuptune commented Jan 11, 2025

stadust left a comment

stadust Jan 11, 2025

stadust Jan 11, 2025

stadust Jan 11, 2025

stadust Jan 11, 2025

stadust Jan 11, 2025

stadust Jan 11, 2025

stadust commented Jan 13, 2025

LG125YT commented Jan 13, 2025

	static GDPS_URL: OnceCell<String> = OnceCell::new();
	pub static REQUEST_BASE: OnceLock<&'static str> = OnceLock::new();

		`rust
		GDPS_URL.get_or_init(\|\| "https://your-custom-gdps-url.com".to_string());`

-`rust
-GDPS_URL.get_or_init(|| "https://your-custom-gdps-url.com".to_string());`
+```rust
+REQUEST_BASE.get_or_init(|| "https://your-custom-gdps-url.com");`
+\```
+in your `fn main` (or anywhere before the first call to any dash-rs functions)

		@@ -7,6 +7,11 @@

		The project is a collaboration with [mgostIH](https://github.com/mgostIH), on whose idea the initial library design is based on and who continues to provide incredibly helpful insights into optimization, Geometry Dash and Rust.

		## Guide

	If you are planning to use this for your own demonlist that isn't related to the main Geometry Dash servers, you can use:
	If you are planning to use this library for interacting with a GDPS, you can use:

Allow specifying URL for GDPS #49

Allow specifying URL for GDPS #49

Conversation

yuptune commented Jan 11, 2025

yuptune commented Jan 11, 2025

stadust left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stadust Jan 11, 2025 • edited Loading

Choose a reason for hiding this comment

stadust commented Jan 11, 2025

yuptune commented Jan 11, 2025

yuptune commented Jan 11, 2025

yuptune commented Jan 11, 2025

stadust left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stadust commented Jan 13, 2025

LG125YT commented Jan 13, 2025

stadust Jan 11, 2025 •

edited

Loading