-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stats/incr/nanmvariance
#6140
base: develop
Are you sure you want to change the base?
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
@Planeshifter please review this PR |
* var accumulator = incrnanmvariance( 3, -2.0 ); | ||
*/ | ||
function incrnanmvariance( W, mean ) { | ||
var delta; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't be inlining the entire implementation of incrmvariance
. Your implementation should be a wrapper around incrmvariance
which provides specialized NaN
handling.
Got it working on it |
@kgryte, could you please review this? I've updated the implementation according to your feedback. Let me know if this looks correct or if there are any further changes needed. Thanks! |
Resolves #5614
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers