Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stats/incr/nanmvariance #6140

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

gkbishnoi07
Copy link
Contributor

@gkbishnoi07 gkbishnoi07 commented Mar 18, 2025

Resolves #5614

Description

What is the purpose of this pull request?

This pull request:

  • add stats/incr/nanmvariance

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Mar 18, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 18, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 18, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmvariance $\color{green}156/156$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}156/156$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gkbishnoi07
Copy link
Contributor Author

@Planeshifter please review this PR

* var accumulator = incrnanmvariance( 3, -2.0 );
*/
function incrnanmvariance( W, mean ) {
var delta;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't be inlining the entire implementation of incrmvariance. Your implementation should be a wrapper around incrmvariance which provides specialized NaN handling.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 18, 2025
@gkbishnoi07
Copy link
Contributor Author

Got it working on it

@gkbishnoi07 gkbishnoi07 requested a review from kgryte March 18, 2025 07:47
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 18, 2025
@gkbishnoi07
Copy link
Contributor Author

@kgryte, could you please review this? I've updated the implementation according to your feedback. Let me know if this looks correct or if there are any further changes needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmvariance
3 participants