Skip to content

test: address review comments for bernoulli quantile native tests #5860 #9543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Jan 5, 2026
+3 −21
Merged

test: address review comments for bernoulli quantile native tests #5860 #9543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a8f6d
test: address review comments for bernoulli quantile native tests
daksha607 Jan 4, 2026
58fc0b1
chore: clean-up
kgryte Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 3 additions & 21 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var tryRequire = require( '@stdlib/utils/try-require' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var abs = require( '@stdlib/math/base/special/abs' );
var NINF = require( '@stdlib/constants/float64/ninf' );
var EPS = require( '@stdlib/constants/float64/eps' );
var tryRequire = require( '@stdlib/utils/try-require' );


// VARIABLES //
Expand Down Expand Up @@ -84,8 +82,6 @@ tape( 'if provided a success probability `p` outside `[0,1]`, the function retur

tape( 'the function evaluates the quantile for `r` given small parameter `p`', opts, function test( t ) {
var expected;
var delta;
var tol;
var r;
var p;
var y;
Expand All @@ -96,21 +92,13 @@ tape( 'the function evaluates the quantile for `r` given small parameter `p`', o
p = smallP.p;
for ( i = 0; i < r.length; i++ ) {
y = quantile( r[i], p[i] );
if ( y === expected[i] ) {
t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
} else {
delta = abs( y - expected[ i ] );
tol = 1.0 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. r: '+r[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
}
t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
}
t.end();
});

tape( 'the function evaluates the quantile for `r` given large parameter `p`', opts, function test( t ) {
var expected;
var delta;
var tol;
var r;
var p;
var y;
Expand All @@ -121,13 +109,7 @@ tape( 'the function evaluates the quantile for `r` given large parameter `p`', o
p = largeP.p;
for ( i = 0; i < r.length; i++ ) {
y = quantile( r[i], p[i] );
if ( y === expected[i] ) {
t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
} else {
delta = abs( y - expected[ i ] );
tol = 1.0 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. r: '+r[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
}
t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
}
t.end();
});