Skip to content

bench: refactor to use string interpolation in tools/snippets #9626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 5 commits into from
Jan 9, 2026
Merged

bench: refactor to use string interpolation in tools/snippets #9626

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b61c7b7
bench: refactor to use string interpolation in buffer/from-array-buffer
ivishal-g Jan 5, 2026
400cdf8
Merge branch 'stdlib-js:develop' into develop
ivishal-g Jan 6, 2026
b71f0ba
Merge branch 'stdlib-js:develop' into develop
ivishal-g Jan 7, 2026
b2d1650
Merge branch 'stdlib-js:develop' into develop
ivishal-g Jan 8, 2026
05d2a40
bench: refactor to use string interpolation i tools/snippets
ivishal-g Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/snippets/benchmark/benchmark.length.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

var bench = require( '@stdlib/bench' );
var pow = require( '@stdlib/math/base/special/pow' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var TODO = require( './../lib' );

Expand All @@ -41,7 +42,7 @@

x = [];
for ( i = 0; i < len; i++ ) {
x.push( null ); // TODO: set values

Check warning on line 45 in tools/snippets/benchmark/benchmark.length.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: set values'
}
return benchmark;

Expand All @@ -56,13 +57,13 @@

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
// TODO: synchronous task

Check warning on line 60 in tools/snippets/benchmark/benchmark.length.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: synchronous task'
if ( TODO/* TODO: condition */ ) {

Check warning on line 61 in tools/snippets/benchmark/benchmark.length.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: condition'
b.fail( 'something went wrong' );
}
}
b.toc();
if ( TODO/* TODO: condition */ ) {

Check warning on line 66 in tools/snippets/benchmark/benchmark.length.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: condition'
b.fail( 'something went wrong' );
}
b.pass( 'benchmark finished' );
Expand Down Expand Up @@ -91,7 +92,7 @@
for ( i = min; i <= max; i++ ) {
len = pow( 10, i );
f = createBenchmark( len );
bench( pkg+':len='+len, f );
bench( format( '%s:len=%d', pkg, len ), f );
}
}

Expand Down
Loading