Skip to content

CI: test.yml never runs on dev, so no feature PR is tested before merge #94

Description

@stonematt

What to build

test.yml runs the suite on dev as well as master, so feature PRs are gated by CI before they land.

Today the workflow triggers only on master:

on:
  push:
    branches: [master]
  pull_request:
    branches: [master]

The branch flow is feature → dev → master. A PR into dev targets dev, so it matches neither trigger, and pushes to dev match neither either. The result is that no feature PR ever runs the test suite — all 198 tests stay idle until the release PR from dev to master.

This surfaced on PR #90, which reported "no checks reported." That looked like a docs-only artifact at the time. It isn't: it is true of every PR into dev, code included. Bugs land on dev untested and are only caught at release, which is the worst moment to find them.

Acceptance criteria

  • test.yml triggers on pull_request targeting dev
  • test.yml triggers on push to dev
  • master coverage is unchanged
  • A PR into dev shows the Node 18/20/22 matrix as required checks

Blocked by

None — can start immediately.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    afk-readyTight enough for autonomous-agent pickup; orthogonal to status:*bugSomething isn't working

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions