Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support showing institution picker first #10397

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Mar 14, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │     2 MiB │     2 MiB │ -829 B │   4.1 MiB │   4.1 MiB │ -1.2 KiB 
     arsc │     1 MiB │     1 MiB │    0 B │     1 MiB │     1 MiB │      0 B 
 manifest │   2.3 KiB │   2.3 KiB │    0 B │     8 KiB │     8 KiB │      0 B 
      res │ 302.9 KiB │ 302.9 KiB │    0 B │   457 KiB │   457 KiB │      0 B 
   native │   6.2 MiB │   6.2 MiB │    0 B │  15.8 MiB │  15.8 MiB │      0 B 
    asset │   7.4 KiB │   7.3 KiB │   -7 B │   7.1 KiB │   7.1 KiB │     -7 B 
    other │  95.1 KiB │  95.1 KiB │  -16 B │ 182.4 KiB │ 182.4 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │   9.6 MiB │   9.6 MiB │ -852 B │  21.6 MiB │  21.6 MiB │ -1.2 KiB 

 DEX     │ old   │ new   │ diff             
─────────┼───────┼───────┼──────────────────
   files │     1 │     1 │  0               
 strings │ 20144 │ 20138 │ -6 (+4 -10)      
   types │  6235 │  6233 │ -2 (+3 -5)       
 classes │  5026 │  5024 │ -2 (+1 -3)       
 methods │ 30045 │ 30041 │ -4 (+1417 -1421) 
  fields │ 17388 │ 17384 │ -4 (+531 -535)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3644 │ 3644 │  0
APK
    compressed     │    uncompressed    │                                
──────────┬────────┼─────────┬──────────┤                                
 size     │ diff   │ size    │ diff     │ path                           
──────────┼────────┼─────────┼──────────┼────────────────────────────────
    2 MiB │ -829 B │ 4.1 MiB │ -1.2 KiB │ ∆ classes.dex                  
   29 KiB │  -12 B │  64 KiB │      0 B │ ∆ META-INF/CERT.SF             
 25.7 KiB │   -6 B │  64 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
  6.5 KiB │   -4 B │ 6.4 KiB │     -4 B │ ∆ assets/dexopt/baseline.prof  
    860 B │   -3 B │   728 B │     -3 B │ ∆ assets/dexopt/baseline.profm 
  1.2 KiB │   +2 B │ 1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
──────────┼────────┼─────────┼──────────┼────────────────────────────────
    2 MiB │ -852 B │ 4.2 MiB │ -1.2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   20144 │ 20138 │ -6 (+4 -10) 
  
  + Lh0/K;
  + [LD/q0;
  + [Lh0/y;
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"1aa8bb7","r8-mode":"full","version":"8.8.27"}
  
  - , animationSpec=
  - Built-in scale
  - LD/s0;
  - La0/L;
  - Lh1/E;
  - Scale(scale=0.92, transformOrigin=
  - TransformOriginInterruptionHandling
  - [LD/r0;
  - [Lh0/x;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"ed8bd40","r8-mode":"full","version":"8.8.27"}
  

TYPES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6235 │ 6233 │ -2 (+3 -5) 
  
  + Lh0/K;
  + [LD/q0;
  + [Lh0/y;
  
  - LD/s0;
  - La0/L;
  - Lh1/E;
  - [LD/r0;
  - [Lh0/x;
  

METHODS:

   old   │ new   │ diff             
  ───────┼───────┼──────────────────
   30045 │ 30041 │ -4 (+1417 -1421) 
  
  + A.a B() → S
  + A.a U() → S
  + A.a c0(S) → g0
  + A.j q(o0)
  + A.k b(g0)
  + B0.h <init>(v, Object, m)
  + B0.n p(S)
  + B1.c f(E0) → v
  + C.f b(k)
  + D.B <clinit>()
  + D.D <clinit>()
  + D.D <init>(Q)
  + D.D B(Q, h) → s0
  + D.D C() → int
  + D.D D(Executor, k)
  + D.D e(boolean, H0) → E0
  + D.D j(I) → g
  + D.D p()
  + D.D r(v, g) → E0
  + D.D toString() → String
  + D.D u(a) → h
  + D.D v(h, h) → h
  + D.D w()
  + D.D x(Matrix)
  + D.D y(Rect)
  + D.E <init>(G, Executor, S, Matrix, S, Rect, k)
  + D.E s(i) → Object
  + D.F <init>(G, S, Matrix, S, Rect, k, i)
  + D.F run()
  + D.G <init>()
  + D.G a(X) → S
  + D.G b(S) → a
  + D.G c()
  + D.G d(X)
  + D.G e(S)
  + D.G f(S)
  + D.G g(int, int, int, int)
  + D.G h(S, int)
  + D.G i(Executor, k)
  + D.H a(X) → S
  + D.H f(S)
  + D.I <init>(int, Object)
  + D.I c(y)
  + D.J <init>(S)
  + D.J <init>(S, K)
  + D.J close()
  + D.K <init>(Executor)
  + D.K a(X) → S
  + D.K c()
  + D.K f(S)
  + D.L <clinit>()
  + D.M clear()
  + D.N a()
  + D.O <clinit>()
  + D.O <init>(S)
  + D.O B(boolean)
  + D.O C(String, S, h) → s0
  + D.O D() → int
  + D.O E(int, List) → boolean
  + D.O e(boolean, H0) → E0
  + D.O i() → Set
  + D.O j(I) → g
  + D.O p()
  + D.O q()
  + D.O r(v, g) → E0
  + D.O t()
  + D.O toString() → String
  + D.O u(a) → h
  + D.O v(h, h) → h
  + D.O w()
  + D.P a() → B0
  + D.P b() → long
  + D.P c() → int
  + D.Q <init>(S, S, int)
  + D.Q c(y)
  + D.S a() → int
  + D.S b() → int
  + D.S e() → a[]
  + D.S j() → P
  + D.S s() → int
  + D.V <clinit>()
  + D.W <init>(int, Object)
  + D.W b(int, q)
  + D.W d(int)
  + D.X <init>(int, int, int, int)
  + D.X B() → S
  + D.X E(W, Executor)
  + D.X G() → int
  + D.X M() → int
  + D.X U() → S
  + D.X a() → int
  + D.X a0()
  + D.X b() → int
  + D.X c(y)
  + D.X close()
  + D.X d(y)
  + D.X e(g0)
  + D.X f(X)
  + D.X g()
  + D.X h()
  + D.X i() → Surface
  + D.Z <clinit>()
  + D.a0 q(o0)
  + D.a j() → P
  + D.b0 <clinit>()
  + D.b0 B()
  + D.b0 C(a0)
  + D.b0 D(j0, h)
  + D.b0 e(boolean, H0) → E0
  + D.b0 i() → Set
  + D.b0 j(I) → g
  + D.b0 r(v, g) → E0
  + D.b0 toString() → String
  + D.b0 u(a) → h
  + D.b0 v(h, h) → h
  + D.b0 w()
  + D.b0 y(Rect)
  + D.d0 <init>(boolean, long, boolean)
  + D.d B() → S
  + D.d U() → S
  + D.d e(v, v) → boolean
  + D.d f(v, v, HashSet) → boolean
  + D.d g(v, LinkedHashSet, HashSet) → v
  + D.d m(HashSet, v, v)
  + D.e0 a() → long
  + D.e0 b(y) → d0
  + D.e <init>(int, f)
  + D.e equals(Object) → boolean
  + D.e hashCode() → int
  + D.e toString() → String
  + D.f0 <init>()
  + D.f0 <init>(G)
  + D.f0 <init>(X)
  + D.f0 B() → S
  + D.f0 E(W, Executor)
  + D.f0 G() → int
  + D.f0 M() → int
  + D.f0 U() → S
  + D.f0 a() → int
  + D.f0 a0()
  + D.f0 b() → int
  + D.f0 c(Collection)
  + D.f0 close()
  + D.f0 d(k)
  + D.f0 e(I)
  + D.f0 f() → G
  + D.f0 g()
  + D.f0 i() → Surface
  + D.f <init>(int, Throwable)
  + D.g0 <init>(S, Size, P)
  + D.g0 j() → P
  + D.g <init>(B0, long, int, Matrix)
  + D.g a() → B0
  + D.g b() → long
  + D.g c() → int
  + D.h0 <init>(n0, k, int)
  + D.h0 run()
  + D.h <init>(Size, Rect, x, int, boolean)
  + D.i0 <init>(AtomicReference, String, int)
  + D.i0 s(i) → Object
  + D.i <init>(m)
  + D.j0 <init>(o0, int)
  + D.j0 run()
  + D.j <init>(int, Surface)
  + D.k0 <init>(a, Surface, int)
  + D.k <init>(Rect, int, int, boolean, Matrix, boolean)
  + D.l0 <init>(o0, Size)
  + D.l0 <init>(Surface)
  + D.l0 <init>(Surface, Size, int)
  + D.l0 f() → a
  + D.l a() → v
  + D.m rejectedExecution(Runnable, ThreadPoolExecutor)
  + D.n0 b(k)
  +
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/institution-picker-first branch 2 times, most recently from 18af6da to 9340377 Compare March 17, 2025 15:33
@tillh-stripe tillh-stripe force-pushed the tillh/institution-picker-first branch from 9340377 to d8a7651 Compare March 17, 2025 16:09
@tillh-stripe tillh-stripe changed the base branch from master to tillh/institution-selected-endpoint March 17, 2025 16:09
@tillh-stripe tillh-stripe force-pushed the tillh/institution-selected-endpoint branch 2 times, most recently from 2f5b000 to 42aa4e1 Compare March 17, 2025 18:59
@tillh-stripe tillh-stripe force-pushed the tillh/institution-selected-endpoint branch from 42aa4e1 to f6e68c9 Compare March 17, 2025 19:28
@tillh-stripe tillh-stripe force-pushed the tillh/institution-picker-first branch 3 times, most recently from ecc3599 to 2d3c835 Compare March 17, 2025 19:50
@tillh-stripe tillh-stripe force-pushed the tillh/institution-selected-endpoint branch 2 times, most recently from 16249ba to 6669770 Compare March 17, 2025 20:00
@tillh-stripe tillh-stripe force-pushed the tillh/institution-picker-first branch 3 times, most recently from edc5957 to 03a3f67 Compare March 17, 2025 21:09
Base automatically changed from tillh/institution-selected-endpoint to master March 18, 2025 00:28
@tillh-stripe tillh-stripe force-pushed the tillh/institution-picker-first branch from 03a3f67 to f13d887 Compare March 18, 2025 00:29
Comment on lines -213 to +248
textAlign = TextAlign.Start,
textAlign = TextAlign.Center,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our footer content is usually centered.

Comment on lines -241 to +276
textAlign = TextAlign.Start,
textAlign = TextAlign.Center,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: Our footer content is usually centered.

@tillh-stripe tillh-stripe force-pushed the tillh/institution-picker-first branch from f13d887 to 47a10eb Compare March 18, 2025 14:24
@tillh-stripe tillh-stripe force-pushed the tillh/institution-picker-first branch from 47a10eb to 70e7c86 Compare March 18, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant