Add test for missing instrument metadata in RPWSpectrogram#177
Open
tejasnarwade wants to merge 4 commits intosunpy:mainfrom
Open
Add test for missing instrument metadata in RPWSpectrogram#177tejasnarwade wants to merge 4 commits intosunpy:mainfrom
tejasnarwade wants to merge 4 commits intosunpy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test to check the behavior of RPWSpectrogram when the
"instrument" key is missing from the metadata.
Previously, accessing this key directly could raise an error. With the
recent change to use a safer access method, this test ensures that the
function handles such cases gracefully and returns False instead of
failing.
This helps improve reliability and prevents similar issues in the future.
PR Description
AI tools were used for: