Skip to content

Add test for missing instrument metadata in RPWSpectrogram #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejasnarwade wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add test for missing instrument metadata in RPWSpectrogram #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f6ec58
Fix doctest failure by skipping optional dependency sunpy_soar
tejasnarwade Mar 17, 2026
3b3b3d2
Improve robustness by safely accessing metadata using dict.get
tejasnarwade Mar 17, 2026
ce7c1e4
Add test to ensure RPWSpectrogram handles missing metadata safely
tejasnarwade Mar 17, 2026
c96ca11
Merge branch 'main' into add-test-rpw-missing-meta
tejasnarwade Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions radiospectra/spectrogram/sources/rpw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class RPWSpectrogram(GenericSpectrogram):

Examples
--------
>>> import sunpy_soar
>>> import sunpy_soar # doctest: +SKIP
>>> from sunpy.net import Fido, attrs as a
>>> from radiospectra.spectrogram import Spectrogram
>>> query = Fido.search(a.Time('2020-07-11', '2020-07-11 23:59'), a.Instrument('RPW'),
Expand All @@ -26,4 +26,4 @@ class RPWSpectrogram(GenericSpectrogram):

@classmethod
def is_datasource_for(cls, data, meta, **kwargs):
return meta["instrument"] == "RPW"
return meta.get("instrument") == "RPW"
9 changes: 9 additions & 0 deletions radiospectra/spectrogram/sources/tests/test_solo_rpw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,12 @@ def test_solo_rpw_hfr(parse_path_moc):
assert spec.end_time.datetime == datetime(2024, 3, 24, 0, 0, 0, 0)
assert spec.wavelength.min == 425 * u.kHz
assert spec.wavelength.max == 16325 * u.kHz

def test_rpw_missing_instrument_key():
from radiospectra.spectrogram.sources.rpw import RPWSpectrogram

meta = {} # missing "instrument"

result = RPWSpectrogram.is_datasource_for(None, meta)

assert result is False
Loading