-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: correct first processing of boundary with pending snippet #16709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 03f6287 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
if (error) { | ||
if (error !== STALE_REACTION) { | ||
if (error !== STALE_REACTION && !batch.branch_obsolete(effect)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this the enhanced async-block-reject-each-during-init test would fail, in other words this fixes a not-yet-reported bug
Fixes #16627
This adjusts the logic of the first processing of an async boundary: Previously, it would only increment/decrement the pending count of a batch on subsequent runs and otherwise deactivate the batch, but this has multiple problems:
$effect
s that were already picked up, because from its point of view there is no pending workAdditionally, currently after async work has finished which causes more effects (from within attachments, or top level
$effect
s after async work) to be created this effects are never run because they are marked as dirty, but there's no flush scheduled.The fix is
to always increment/decrement the pending countUpdate: Turns out this was on purpose, so we gotta keep not incrementing/decrementing on pending boundaries, else a state change that has causes a pending boundary to appear will be deferred which we don't want, since the async work happens "hidden" behind the pending boundary; added a test. We need to solve this differently by not collecting these effects until all async work is done$effect
s to the component context (todo)This also cleans up our scheduling system - everything goes through
queue_micro_task
now, before this change batching was always in microtasks (meaning flushSync wouldn't really work correctly) and in some weird order (LIFO insteand of FIFO), andflushSync
didn't take into account pending tasks.There's some tests failing.
One of them needs #16698 merged first, anotherone needs #16621 (that test was always failing when you tried it in the playground, weirdly the test passed up until now for some reason).The remaining need investigation.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint