Skip to content

chore(swc_allocator): Add #[inline] to allocator methods #10066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 21, 2025

Description:

It's necessary for allocators, for an unknown reason

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 5ec5110

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title #[inline] chore(swc_allocator): Add #[inline] to allocator methods Feb 21, 2025
@kdy1 kdy1 marked this pull request as ready for review February 21, 2025 02:13
@kdy1 kdy1 requested a review from a team as a code owner February 21, 2025 02:13
@kdy1 kdy1 merged commit 853eb53 into main Feb 21, 2025
172 checks passed
Copy link
Member Author

kdy1 commented Feb 21, 2025

Merge activity

  • Feb 21, 11:44 AM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 deleted the kdy1/allocator-inline branch February 21, 2025 02:44
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #10066 will degrade performances by 4.33%

Comparing kdy1/allocator-inline (5ec5110) with main (52caf23)

Summary

⚡ 2 improvements
❌ 3 regressions
✅ 186 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 174.2 ms 168.1 ms +3.62%
es/full/minify/libraries/lodash 185.7 ms 194.1 ms -4.33%
es/full/minify/libraries/moment 104.8 ms 109.4 ms -4.18%
es/lints/libs/moment 5.7 ms 5.5 ms +5.3%
es/minifier/libs/moment 82.8 ms 85.8 ms -3.47%

@kdy1 kdy1 modified the milestones: Planned, v1.11.1 Feb 21, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant