Skip to content

perf(es/minifier): Use arena allocator for ProgramData #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 21, 2025

Description:

I'm not sure about the reason, but it seems like it's increasing RSS, at least with the current approach. Maybe it's not freeing too much memory for a while.

Related issue:

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 0347849

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

kdy1 commented Feb 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kdy1 kdy1 changed the title lifetime perf(es/minifier): Use arena allocator for ProgramData Feb 21, 2025
@kdy1 kdy1 changed the base branch from kdy1/swc-common-fix to graphite-base/10068 February 21, 2025 02:25
@kdy1 kdy1 changed the base branch from graphite-base/10068 to kdy1/alloc-types February 21, 2025 02:26
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #10068 will degrade performances by 8.35%

Comparing kdy1/min-arena (0347849) with main (6a90b1f)

Summary

❌ 4 regressions
✅ 187 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/moment 104.7 ms 110.2 ms -5.01%
es/full/minify/libraries/vue 232.3 ms 241.5 ms -3.83%
es/minifier/libs/lodash 150.6 ms 158.5 ms -4.99%
es/minifier/libs/moment 82 ms 89.5 ms -8.35%

@kdy1 kdy1 changed the base branch from kdy1/alloc-types to graphite-base/10068 February 21, 2025 03:10
@kdy1 kdy1 force-pushed the graphite-base/10068 branch from 63045b7 to 853eb53 Compare February 21, 2025 03:10
@kdy1 kdy1 changed the base branch from graphite-base/10068 to main February 21, 2025 03:10
@kdy1 kdy1 added this to the Planned milestone Feb 21, 2025
@kdy1
Copy link
Member Author

kdy1 commented Mar 17, 2025

Closing as this increases RSS

@kdy1 kdy1 closed this Mar 17, 2025
@kdy1 kdy1 deleted the kdy1/min-arena branch March 17, 2025 13:41
@kdy1 kdy1 modified the milestones: Planned, v1.11.11 Mar 17, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant