[LLDB] Filter out -Werror options when setting up -cc1 Clang Invocations#12839
Open
adrian-prantl wants to merge 1 commit intoswiftlang:stable/21.xfrom
Open
[LLDB] Filter out -Werror options when setting up -cc1 Clang Invocations#12839adrian-prantl wants to merge 1 commit intoswiftlang:stable/21.xfrom
adrian-prantl wants to merge 1 commit intoswiftlang:stable/21.xfrom
Conversation
adrian-prantl
requested review from
cachemeifyoucan
and removed request for
a team
Author
|
@swift-ci test |
JDevlieghere
approved these changes
Apr 24, 2026
cachemeifyoucan
requested changes
Apr 24, 2026
adrian-prantl
force-pushed
the
174422552
branch
from
a9ddaf0 to
917099b
Compare
Author
|
@swift-ci test |
The non-caching code path was already doing this, but the code path for cc1 flags was missing this functionality. Even though LLDB is replaying the compile-time compiler invocation, we have seen reports where additional warnings get diagnosed at debug time, effectively rendering the debug session unusable. rdar://174422552
adrian-prantl
force-pushed
the
174422552
branch
from
917099b to
a027462
Compare
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-caching code path was already doing this, but the code path for cc1 flags was missing this functionality. Even though LLDB is replaying the compile-time compiler invocation, we have seen reports where additional warnings get diagnosed at debug time, effectively rendering the debug session unusable.
rdar://174422552