Skip to content

[LLDB] Filter out -Werror options when setting up -cc1 Clang Invocations #12839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrian-prantl merged 1 commit into from
Apr 27, 2026
+9 −5
Merged

[LLDB] Filter out -Werror options when setting up -cc1 Clang Invocations #12839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2112,12 +2112,15 @@ void SwiftASTContext::AddExtraClangCC1Args(
else
++it;
}
invocation.getFrontendOpts().ModuleFiles.erase(
llvm::remove_if(invocation.getFrontendOpts().ModuleFiles,
[&](const auto &mod) { return !CheckFileExists(mod); }),
invocation.getFrontendOpts().ModuleFiles.end());
llvm::erase_if(invocation.getFrontendOpts().ModuleFiles,
[&](const auto &mod) { return !CheckFileExists(mod); });
}

// Remove -Werror flags.
Comment thread
adrian-prantl marked this conversation as resolved.
llvm::erase_if(
invocation.getDiagnosticOpts().Warnings,
[](StringRef Warning) { return Warning.starts_with("error"); });

invocation.generateCC1CommandLine(
[&](const llvm::Twine &arg) { dest.push_back(arg.str()); });

Expand Down
2 changes: 1 addition & 1 deletion lldb/test/API/lang/swift/clangimporter/caching/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
SWIFT_SOURCES := main.swift
SWIFT_ENABLE_EXPLICIT_MODULES := YES
SWIFTFLAGS_EXTRAS = -I$(SRCDIR) -I/TEST_DIR -F/FRAMEWORK_DIR -cache-compile-job -cas-path $(BUILDDIR)/cas
SWIFTFLAGS_EXTRAS = -I$(SRCDIR) -I/TEST_DIR -F/FRAMEWORK_DIR -cache-compile-job -cas-path $(BUILDDIR)/cas -Xcc -Werror

all: a.out cas-config

Expand Down
1 change: 1 addition & 0 deletions lldb/test/API/lang/swift/clangimporter/caching/TestSwiftClangImporterCaching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@ def test(self):
# CHECK: SwiftASTContextForExpressions(module: "a", cu: "main.swift")::LogConfiguration() -- -DADDED=1
# CHECK: SwiftASTContextForExpressions(module: "a", cu: "main.swift")::LogConfiguration() -- -DEXTRA=1
# CHECK: SwiftASTContextForExpressions(module: "a", cu: "main.swift") Module import remark: loaded module 'ClangA'
# CHECK-NOT: -Werror
# CHECK-NOT: -cc1
# CHECK-NOT: Clang error