[dsymutil] Report error when section offsets exceed DWARF32 limit (#1…#12842
Open
JDevlieghere wants to merge 2 commits intostable/21.xfrom
Open
[dsymutil] Report error when section offsets exceed DWARF32 limit (#1…#12842JDevlieghere wants to merge 2 commits intostable/21.xfrom
JDevlieghere wants to merge 2 commits intostable/21.xfrom
Conversation
…vm#193867) When linking very large binaries, debug section offsets can exceed the 4 GB DWARF32 limit. Previously this caused an assertion in MCStreamer::emitIntValue when trying to emit an overflowing DW_FORM_sec_offset value. Detect the overflow at the point where section offsets are patched in DWARFStreamer (for .debug_ranges, .debug_rnglists, .debug_loc, .debug_loclists) and in DWARFLinker (for .debug_line and .debug_addr). rdar://107413300 (cherry picked from commit ca934b8)
Author
|
@swift-ci test |
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…93867)
When linking very large binaries, debug section offsets can exceed the 4 GB DWARF32 limit. Previously this caused an assertion in MCStreamer::emitIntValue when trying to emit an overflowing DW_FORM_sec_offset value.
Detect the overflow at the point where section offsets are patched in DWARFStreamer (for .debug_ranges, .debug_rnglists, .debug_loc, .debug_loclists) and in DWARFLinker (for .debug_line and .debug_addr).
rdar://107413300
(cherry picked from commit ca934b8)