Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple testing paths on Windows #1995

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

bnbarham
Copy link
Contributor

No description provided.

@bnbarham bnbarham requested a review from ahoppen as a code owner February 24, 2025 22:49
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@swift-ci please test Windows platform

1 similar comment
@bnbarham
Copy link
Contributor Author

@swift-ci please test Windows platform

@bnbarham
Copy link
Contributor Author

@swift-ci please test Windows platform

@ahoppen
Copy link
Member

ahoppen commented Feb 26, 2025

For future reference, I filed #2009 to enable the macro expansion tests on Windows.

We re-use the swift-syntax libs from the real build to avoid re-building
it in these tests, but it currently only handles the SwiftPM build and
not Windows.

Temporarily continue skipping these on Windows to unblock CI.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@swift-ci please test Windows platform

@bnbarham
Copy link
Contributor Author

swiftlang/swift#79543 passed, which runs sourcekit-lsp tests. Merging to unblock all the Windows builds.

@bnbarham bnbarham merged commit 85e0f96 into swiftlang:main Feb 26, 2025
0 of 2 checks passed
@bnbarham bnbarham deleted the fix-backslash branch February 26, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants