Replace fatalError with proper error handling for non-incremental #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clemo97
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
reviewed
Aug 4, 2025
| @@ -519,7 +519,8 @@ package actor SourceKitLSPServer { | |||
| syncKind = .incremental | |||
| } | |||
| guard syncKind == .incremental else { | |||
| fatalError("non-incremental update not implemented") | |||
| logger.error("Received non-incremental update request, which is not implemented") | |||
There was a problem hiding this comment.
We don’t need a logger.error call here. Throwing the error will log an error from the orLog call in line 480.
There was a problem hiding this comment.
Hello, thanks for the feedback.
I've made the necessary changes in the new commit.
ahoppen
approved these changes
Aug 4, 2025
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2210