Skip to content

Replace fatalError with proper error handling for non-incremental #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

Replace fatalError with proper error handling for non-incremental #2227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d065de
Replace fatalError with proper error handling for non-incremental sync
Clemo97 Aug 3, 2025
5202037
Remove redundant error logging in synckind check
Clemo97 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SourceKitLSP/SourceKitLSPServer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ package actor SourceKitLSPServer {
syncKind = .incremental
}
guard syncKind == .incremental else {
fatalError("non-incremental update not implemented")
throw ResponseError.internalError("non-incremental update not implemented")
}

await service.clientInitialized(InitializedNotification())
Expand Down